From: Benjamin LaHaise <bcrl@redhat.com>
To: Mingming Cao <cmm@us.ibm.com>
Cc: akpm@digeo.com, linux-kernel@vger.kernel.org, linux-aio@kvack.org
Subject: Re: [PATCH] Small bug fix for aio
Date: Wed, 23 Apr 2003 23:14:27 -0400 [thread overview]
Message-ID: <20030423231427.A9036@redhat.com> (raw)
In-Reply-To: <1051062904.2808.37.camel@w-ming.beaverton.ibm.com>; from cmm@us.ibm.com on Tue, Apr 22, 2003 at 06:54:51PM -0700
On Tue, Apr 22, 2003 at 06:54:51PM -0700, Mingming Cao wrote:
> Here is a trivial patch fixed a bug in ioctx_alloc(). If
> aio_setup_ring() failed, ioctx_alloc() should pass the return error from
> aio_setup_ring() back to sys_io_setup().
This particular case was intentional: -ENOMEM really is the right return
code when the ring cannot be allocated. Mixing it up with the potential
return codes from do_mmap or other functions might result in a very
nonsensical return. Perhaps someone can provide an arguement in favour
of propagating the value, but I think it really can only mean "you asked
the kernel to allocate too much memory or did something stupidly buggy with
threads". Cheers,
-ben
--
Junk email? <a href="mailto:aart@kvack.org">aart@kvack.org</a>
next prev parent reply other threads:[~2003-04-24 3:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-23 1:54 [PATCH] Small bug fix for aio Mingming Cao
2003-04-24 3:14 ` Benjamin LaHaise [this message]
2003-04-24 20:21 ` Mingming Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030423231427.A9036@redhat.com \
--to=bcrl@redhat.com \
--cc=akpm@digeo.com \
--cc=cmm@us.ibm.com \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).