From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262680AbTDXKQw (ORCPT ); Thu, 24 Apr 2003 06:16:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262682AbTDXKQw (ORCPT ); Thu, 24 Apr 2003 06:16:52 -0400 Received: from ns.virtualhost.dk ([195.184.98.160]:47539 "EHLO virtualhost.dk") by vger.kernel.org with ESMTP id S262680AbTDXKQv (ORCPT ); Thu, 24 Apr 2003 06:16:51 -0400 Date: Thu, 24 Apr 2003 12:28:51 +0200 From: Jens Axboe To: Erik Andersen , Marcelo Tosatti , linux-kernel Subject: Re: [PATCH] 2.4.21-rc1 pointless IDE noise reduction Message-ID: <20030424102851.GI8775@suse.de> References: <20030424093443.GA7180@codepoet.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030424093443.GA7180@codepoet.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 24 2003, Erik Andersen wrote: > The ide driver does not list whether drives support things like > write cache, SMART, SECURITY ERASE UNIT. But for some silly > reason it tells us at boot whether each drive is capable of > supporting the Host Protected Area feature set. If people want > to know the capabilites of their drive, they can run 'hdparm' > and find out. > > This patch removes this pointless noise. Please apply, > > > --- linux/drivers/ide/ide-disk.c.orig 2003-04-24 03:23:53.000000000 -0600 > +++ linux/drivers/ide/ide-disk.c 2003-04-24 03:24:54.000000000 -0600 > @@ -1133,10 +1133,7 @@ > */ > static inline int idedisk_supports_host_protected_area(ide_drive_t *drive) > { > - int flag = (drive->id->cfs_enable_1 & 0x0400) ? 1 : 0; > - if (flag) > - printk("%s: host protected area => %d\n", drive->name, flag); > - return flag; > + return((drive->id->cfs_enable_1 & 0x0400) ? 1 : 0); > } Seconded, it causes a lot more confusion than it does good. -- Jens Axboe