From: Christoph Hellwig <hch@infradead.org>
To: Marc Zyngier <mzyngier@freesurf.fr>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] aha1740 update
Date: Thu, 24 Apr 2003 13:36:41 +0100 [thread overview]
Message-ID: <20030424133641.A29770@infradead.org> (raw)
In-Reply-To: <wrpk7dkt84r.fsf@hina.wild-wind.fr.eu.org>; from mzyngier@freesurf.fr on Thu, Apr 24, 2003 at 02:03:32PM +0200
On Thu, Apr 24, 2003 at 02:03:32PM +0200, Marc Zyngier wrote:
> * forms part of the process of creating an executable the information
> @@ -44,6 +47,11 @@
> #include <asm/system.h>
> #include <asm/io.h>
>
> +#include <linux/init.h>
> +#include <linux/device.h>
> +#include <linux/eisa.h>
> +#include <linux/dma-mapping.h>
If there's a chance put this before the <asm/*.h> includes.
> +/* This should really fit in driver/scsi/scsi.h, along with
> + * scsi_to_{pci,sbus}_dma_dir.... */
Right. Please submit a patch to James.
> +/* Eventually this will go into an include file, but this will be later */
No. (okay, you just moved it..)
> +static Scsi_Host_Template driver_template = AHA1740;
Please initialize the struct here instead of the macro obsfucation.
(again not yhour fault, but you're touching the driver so please
clean it up while at it).
> -#include "scsi_module.c"
> +static __init int aha1740_init (void)
> +{
> + driver_template.module = THIS_MODULE;
Please do this at compile-time.
> /* Okay, you made it all the way through. As of this writing, 3/31/93, I'm
> brad@saturn.gaylord.com or brad@bradpc.gaylord.com. I'll try to help as time
This comment looks a _bit_ outdated to me, what about nuking it?
Well, and as you're touching the driver big time a cleanup to follow
Documentation/CondingStyle would be nice.
next prev parent reply other threads:[~2003-04-24 12:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-24 12:03 [PATCH] aha1740 update Marc Zyngier
2003-04-24 12:36 ` Christoph Hellwig [this message]
2003-04-24 13:34 ` Marc Zyngier
2003-04-24 13:39 ` Christoph Hellwig
2003-04-25 13:24 ` [PATCH] aha1740 update, take #2 Marc Zyngier
2003-04-25 13:40 ` Christoph Hellwig
2003-04-24 18:49 ` [PATCH] aha1740 update Alan Cox
2003-04-25 9:56 ` Marc Zyngier
2003-04-25 9:02 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030424133641.A29770@infradead.org \
--to=hch@infradead.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mzyngier@freesurf.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).