From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263657AbTDXN1U (ORCPT ); Thu, 24 Apr 2003 09:27:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263658AbTDXN1U (ORCPT ); Thu, 24 Apr 2003 09:27:20 -0400 Received: from phoenix.mvhi.com ([195.224.96.167]:21779 "EHLO phoenix.infradead.org") by vger.kernel.org with ESMTP id S263657AbTDXN1S (ORCPT ); Thu, 24 Apr 2003 09:27:18 -0400 Date: Thu, 24 Apr 2003 14:39:25 +0100 From: Christoph Hellwig To: Marc Zyngier Cc: Christoph Hellwig , Alan Cox , linux-kernel@vger.kernel.org Subject: Re: [PATCH] aha1740 update Message-ID: <20030424143925.A31989@infradead.org> Mail-Followup-To: Christoph Hellwig , Marc Zyngier , Alan Cox , linux-kernel@vger.kernel.org References: <20030424133641.A29770@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: ; from mzyngier@freesurf.fr on Thu, Apr 24, 2003 at 03:34:25PM +0200 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 24, 2003 at 03:34:25PM +0200, Marc Zyngier wrote: > >>>>> "CH" == Christoph Hellwig writes: > > >> +/* This should really fit in driver/scsi/scsi.h, along with > >> + * scsi_to_{pci,sbus}_dma_dir.... */ > > CH> Right. Please submit a patch to James. > > I think this would cause some troubles. I would have to include > linux/dma-mapping in driver/scsi/scsi.h, but many non-PCI > architectures are still including asm-generic/dma-mapping.h, which has > lots of references to PCI functions... I'm afraid this would clash > badly on, say, sparc or m68k... Then make it conditional on COFIG_EISA && CONFIG_MAC for now and add a big FIXME. I'll break it at some point then, so I'll get blamed instead of you :)