From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263789AbTDXRUp (ORCPT ); Thu, 24 Apr 2003 13:20:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263790AbTDXRUo (ORCPT ); Thu, 24 Apr 2003 13:20:44 -0400 Received: from ns.virtualhost.dk ([195.184.98.160]:40935 "EHLO virtualhost.dk") by vger.kernel.org with ESMTP id S263789AbTDXRUn (ORCPT ); Thu, 24 Apr 2003 13:20:43 -0400 Date: Thu, 24 Apr 2003 19:32:28 +0200 From: Jens Axboe To: Nick Piggin Cc: Zwane Mwaikambo , Linux Kernel Subject: Re: Badness in as-iosched:1210 Message-ID: <20030424173228.GT8775@suse.de> References: <3EA7A0CC.50005@cyberone.com.au> <20030424084717.GF8775@suse.de> <3EA81A3B.80800@cyberone.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3EA81A3B.80800@cyberone.com.au> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 25 2003, Nick Piggin wrote: > Jens Axboe wrote: > > >On Thu, Apr 24 2003, Nick Piggin wrote: > > > >>Zwane Mwaikambo wrote: > >> > >> > >>>I'm not sure wether you want this, it was during error handling from the > >>>HBA driver (source was disk error). > >>> > >>>scsi1: ERROR on channel 0, id 3, lun 0, CDB: Read (10) 00 00 7f de 60 00 > >>>00 80 00 Info fld=0x7fdeb2, Current sdd: sense key Medium Error > >>>Additional sense: Unrecovered read error > >>>end_request: I/O error, dev sdd, sector 8380032 > >>>Badness in as_add_request at drivers/block/as-iosched.c:1210 > >>> > >>> > >>Thanks I'll have a look. > >> > > > >The debug check looks broken, request could have come from somewhere > >else than the block pool. > > > Thats right. I thought these requests would all be > !blk_fs_request()s though. It should be only the debug > checks which are wrong. Exactly, the rest looks ok, the debug trigger is wrong :). The add_request() strategy is the entry point for all types of requests, not just blk_fs_request() -- Jens Axboe