From: Chuck Ebbert <76306.1226@compuserve.com>
To: Timothy Miller <miller@techsource.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] 2.4.21-rc1 pointless IDE noise reduction
Date: Thu, 24 Apr 2003 19:25:39 -0400 [thread overview]
Message-ID: <200304241929_MC3-1-35E8-687C@compuserve.com> (raw)
Timothy Miller wrote:
> Two alternatives:
>
> (a) !!(x & 0x400)
>
> (b) (x & 0x400) >> 10
I like either of these:
#define FOO_BITS 0x400
#define test_mask(t,m) ( !!((t) & (m)) )
...
return test_mask(x, FOO_BITS);
or
return (x & FOO_BITS) != 0;
Those double exclamation points should be hidden in macros. :)
------
Chuck
next reply other threads:[~2003-04-24 23:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-24 23:25 Chuck Ebbert [this message]
2003-04-25 15:08 ` [PATCH] 2.4.21-rc1 pointless IDE noise reduction Timothy Miller
-- strict thread matches above, loose matches on Subject: below --
2003-04-24 15:25 Chuck Ebbert
2003-04-24 15:59 ` Richard B. Johnson
2003-04-24 16:31 ` Timothy Miller
2003-04-24 16:46 ` Richard B. Johnson
2003-04-24 17:15 ` Timothy Miller
2003-04-24 18:27 ` Willy Tarreau
2003-04-24 19:00 ` Timothy Miller
2003-04-25 18:14 ` Bill Davidsen
2003-04-25 18:30 ` Richard B. Johnson
2003-04-24 9:34 Erik Andersen
2003-04-24 10:28 ` Jens Axboe
2003-04-27 12:21 ` Adrian Bunk
2003-04-27 17:44 ` Erik Andersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200304241929_MC3-1-35E8-687C@compuserve.com \
--to=76306.1226@compuserve.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miller@techsource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).