From: Harald Welte <laforge@netfilter.org>
To: "David S. Miller" <davem@redhat.com>
Cc: Maciej Soltysiak <solt@dns.toxicfilms.tv>,
linux-kernel@vger.kernel.org,
netfilter-devel@lists.netfilter.org, kisza@sunbeam.gnumonks.org
Subject: Re: [RESEND][PATCH] net/ipv6/netfilter warnings removal
Date: Sun, 27 Apr 2003 15:12:06 +0200 [thread overview]
Message-ID: <20030427131206.GL990@sunbeam.de.gnumonks.org> (raw)
In-Reply-To: <1051159844.18160.1.camel@rth.ninka.net>
[-- Attachment #1: Type: text/plain, Size: 897 bytes --]
On Wed, Apr 23, 2003 at 09:50:44PM -0700, David S. Miller wrote:
> On Wed, 2003-04-23 at 05:38, Maciej Soltysiak wrote:
> > And here is the patch to remove those by using casts.
>
> It's kind of rediculious that these modules don't use the
> existing AH/ESP/etc. header structure types (ip_auth_header et
> al.)
It's because they predate any AH/ESP stuff in the linux kernel.
I'm not saying this as an excuse, just as an explanation.
Kisza: Can you work on making the changes suggested by DaveM?
> Thanks.
--
- Harald Welte <laforge@netfilter.org> http://www.netfilter.org/
============================================================================
"Fragmentation is like classful addressing -- an interesting early
architectural error that shows how much experimentation was going
on while IP was being designed." -- Paul Vixie
[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]
prev parent reply other threads:[~2003-04-27 13:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-05 14:21 [PATCH] C99 Initialisers for drivers/video Maciej Soltysiak
2003-04-05 18:51 ` James Simmons
2003-04-07 19:16 ` [PATCH] C99 Initialisers around scsi + ac97_codec.c Maciej Soltysiak
2003-04-23 12:38 ` [RESEND][PATCH] net/ipv6/netfilter warnings removal Maciej Soltysiak
2003-04-24 4:50 ` David S. Miller
2003-04-27 13:12 ` Harald Welte [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030427131206.GL990@sunbeam.de.gnumonks.org \
--to=laforge@netfilter.org \
--cc=davem@redhat.com \
--cc=kisza@sunbeam.gnumonks.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@lists.netfilter.org \
--cc=solt@dns.toxicfilms.tv \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).