linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shantanu Goel <sgoel01@yahoo.com>
To: linux-kernel@vger.kernel.org
Subject: 2.4.21-rc1-ac2 NFS close-to-open question
Date: Sun, 27 Apr 2003 08:12:01 -0700 (PDT)	[thread overview]
Message-ID: <20030427151201.27191.qmail@web12802.mail.yahoo.com> (raw)

Hi,

In fs/nfs/inode.c:nfs_open() shouldn't the following

if (NFS_SERVER(inode)->flags & NFS_MOUNT_NOCTO) {
  err =
_nfs_revalidate_inode(NFS_SERVER(inode),inode);
  if (err)
    goto out;
}

be

if (!(NFS_SERVER(inode)->flags & NFS_MOUNT_NOCTO)) {
  err =
_nfs_revalidate_inode(NFS_SERVER(inode),inode);
  if (err)
    goto out;
}

If we desire close-to-open consistency, and assuming
my reading of the code is correct, is this a typo?

Thanks.
Shantanu



__________________________________
Do you Yahoo!?
The New Yahoo! Search - Faster. Easier. Bingo.
http://search.yahoo.com

             reply	other threads:[~2003-04-27 14:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-27 15:12 Shantanu Goel [this message]
2003-04-27 15:56 ` 2.4.21-rc1-ac2 NFS close-to-open question Trond Myklebust
2003-05-06  2:28   ` Mike Fedyk
2003-05-06 12:50     ` Trond Myklebust
2003-05-06 16:21       ` Mike Fedyk
2003-05-07 19:37       ` Mike Fedyk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030427151201.27191.qmail@web12802.mail.yahoo.com \
    --to=sgoel01@yahoo.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).