From: Andrew Morton <akpm@digeo.com>
To: Keith Mannthey <kmannth@us.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC] clustered apic irq affinity fix for i386
Date: Wed, 30 Apr 2003 16:36:37 -0700 [thread overview]
Message-ID: <20030430163637.04f06ba6.akpm@digeo.com> (raw)
In-Reply-To: <1051744032.16886.80.camel@dyn9-47-17-180.beaverton.ibm.com>
Keith Mannthey <kmannth@us.ibm.com> wrote:
>
> Hello all,
> Machines with clustered apics are buggy when it comes to setting irq
> affinity.
You stand accused of crimes against whitespace.
- The patch uses eight-spaces everywhere. Please use eight-stop tabs.
- Funny comment format:
/*we want to be careful what we write we are in clustered mode
*if the mask came from pending_irq_balance_apicid we are ok because
*it was generated with cpu_to_logical_apicid*/
should be
/*
* We want to be careful what we write we are in clustered mode if the mask
* came from pending_irq_balance_apicid we are ok because it was generated
* with cpu_to_logical_apicid.
*/
- 1e16-column xterms. Please aim for 80-columns:
static inline void io_apic_write_affinity(unsigned int apic, unsigned int reg, unsigned int mask, unsigned int irq)
should be:
static inline void io_apic_write_affinity(unsigned int apic,
unsigned int reg, unsigned int mask, unsigned int irq)
or
static inline void
io_apic_write_affinity(unsigned int apic, unsigned int reg,
unsigned int mask, unsigned int irq)
- non-K&R braces:
if ((pending_irq_balance_apicid[irq] == mask) || (irqbalance_disabled))
{
mask = mask << 24;
io_apic_write(apic,reg,mask);
}
else
{
printk ("Trying to write abartry affinity value to ioapic! Not allowed!");
}
}
should be:
if ((pending_irq_balance_apicid[irq] == mask) || irqbalance_disabled) {
mask = mask << 24;
io_apic_write(apic,reg,mask);
} else {
printk("Trying to write abartry affinity value to ioapic! Not allowed!");
}
(note: no space between "printk" and "(")
(s/abartry/arbitrary/)
(best replace that printk with a BUG() or a WARN_ON(1))
(or split the string up so it fits in 80-cols)
- Funny comments:
/*only the first 8 bits are valid*/
should be:
/* Only the first 8 bits are valid */
Could you please take a look at all that and resend?
Thanks.
next prev parent reply other threads:[~2003-04-30 23:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-30 23:07 [RFC] clustered apic irq affinity fix for i386 Keith Mannthey
2003-04-30 23:36 ` Andrew Morton [this message]
2003-05-01 1:05 ` Keith Mannthey
2003-05-01 2:22 ` Andrew Morton
2003-05-01 2:49 ` William Lee Irwin III
2003-05-01 4:07 ` Martin J. Bligh
2003-05-01 17:51 ` Keith Mannthey
2003-05-06 0:04 ` [RFC][PATCH] fix for clusterd io_apics Keith Mannthey
2003-05-06 15:15 ` Martin J. Bligh
2003-05-01 9:10 ` [RFC] clustered apic irq affinity fix for i386 Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030430163637.04f06ba6.akpm@digeo.com \
--to=akpm@digeo.com \
--cc=kmannth@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).