From: Andrew Morton <akpm@digeo.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: must-fix list for 2.6.0
Date: Thu, 1 May 2003 11:42:29 -0700 [thread overview]
Message-ID: <20030501114229.64fbbfa2.akpm@digeo.com> (raw)
In-Reply-To: <20030501153325.A15458@infradead.org>
Christoph Hellwig <hch@infradead.org> wrote:
>
> drivers/scsi/
>
> - large parts of the locking are hosed or not existant
> o shost->my_devices isn't locked down at all
> o the host list ist locked but not refcounted, mess can
> happen when the spinlock is dropped
> o there are lots of members of struct Scsi_Host/scsi_device/scsi_cmnd
> with very unclear locking, many of them probably want to become
> atomic_t's or bitmaps (for the 1bit bitfields).
> o there's lots of volatile abuse in the scsi code that needs to
> be thought about.
> o there's some global variables incremented without any locks
Thanks.
> fs/devfs/
>
> - there's a fundamental lookup vs devfsd race that's only fixable
> by introducing a lookup vs devfs deadlock. I can't see how this
> is fixable without getting rid of the current devfsd design.
> Mandrake seems to have a workaround for this so this is at least
> not triggered so easily, but that's not what I'd considere a fix..
Look. Please. If you have the time, let's just put it out of its misery.
I had two concerns with smalldevfs:
- It's dropping a semaphore (i_sem?) during its synchronous userspace
callout. That was for deadlock avoidance and may have introduced a race.
- The new userspace doesn't support the compatibility names. Just some
config file, or a tarball or a dang shell script full of `ln -s'
calls would fix that up, I think.
next prev parent reply other threads:[~2003-05-01 18:29 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-29 22:57 must-fix list for 2.6.0 Andrew Morton
2003-04-29 23:22 ` John Bradford
2003-04-29 23:37 ` Andrew Morton
2003-04-30 3:19 ` William Lee Irwin III
2003-04-30 4:45 ` Andrew Morton
2003-04-30 4:52 ` William Lee Irwin III
2003-05-01 4:32 ` William Lee Irwin III
2003-04-30 8:30 ` Benjamin Herrenschmidt
2003-04-30 10:16 ` Maciej Soltysiak
2003-04-30 19:11 ` Andrew Morton
2003-04-30 23:11 ` Rick Lindsley
2003-04-30 23:21 ` Andrew Morton
2003-04-30 23:47 ` viro
2003-04-30 23:59 ` Andrew Morton
2003-05-01 6:27 ` Christoph Hellwig
2003-05-01 5:49 ` Shawn
2003-05-01 10:14 ` Christoph Hellwig
2003-05-01 9:47 ` Alan Cox
2003-05-01 15:44 ` Robert Love
2003-05-01 0:09 ` Robert Love
2003-05-01 0:51 ` Gerrit Huizenga
2003-05-01 5:40 ` Dave Hansen
2003-05-01 11:57 ` Bill Huey
2003-04-30 23:53 ` Robert Love
2003-05-01 8:36 ` Arjan van de Ven
2003-05-01 8:42 ` Andrew Morton
2003-05-01 8:47 ` Arjan van de Ven
2003-04-30 23:41 ` Robert Love
2003-05-01 16:50 ` Hubertus Franke
2003-05-01 3:21 ` Mike Galbraith
2003-05-01 6:26 ` Mike Galbraith
2003-05-01 14:33 ` Christoph Hellwig
2003-05-01 18:42 ` Andrew Morton [this message]
2003-05-01 18:47 ` Christoph Hellwig
2003-05-02 1:57 ` Andreas Boman
[not found] <20030429155731.07811707.akpm@digeo.com.suse.lists.linux.kernel>
2003-04-30 1:36 ` Andi Kleen
2003-04-30 18:09 ` Pavel Machek
2003-04-30 18:15 ` Andi Kleen
2003-04-30 19:11 ` Pavel Machek
[not found] <20030429231009$1e6b@gated-at.bofh.it>
2003-04-30 4:55 ` Florian Weimer
2003-04-30 10:18 ` Maciej Soltysiak
2003-05-01 11:24 ` David S. Miller
2003-05-01 11:27 ` Florian Weimer
2003-05-01 12:03 ` David S. Miller
2003-05-01 12:05 ` David S. Miller
2003-05-02 16:28 ` Carl-Daniel Hailfinger
2003-05-02 21:14 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030501114229.64fbbfa2.akpm@digeo.com \
--to=akpm@digeo.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).