2.5.68-mm3 and a simple mistake

2.5.68-mm3 and a simple mistake

[Kimmo Sundqvist]

What have I done wrong?

This is Debian 3.0r1.  I am running 2.5.68-osdl2 and decided to try 
2.5.68-mm3.  I did tar -xvf with linux-2.5.68.tar in /usr/src, then bunzipped 
2.5.68-mm3.bz2 in /usr/src.  Before beginning this, I had removed the 2.5.68 
directory I had used with compiling -osdl2, so the linux-2.5.68 dir was 
fresh.  I did "patch -p0 < 2.5.68-mm3" which went through fine.  I configured 
it to my liking, and since this is Debian, did "make-kpkg -rev dp1 
kernel_image" (dp = dual processor, as opposed to my little brother's old 
Pentium 133).  That had worked with 2.5.68-osdl2, but now I got:

*
* Library routines
*
CRC32 functions (CRC32) [M/n/y/?] m
make[1]: Leaving directory `/usr/src/linux-2.5.68'
/usr/bin/make -f ./debian/rules dummy_do_dep
make[1]: Entering directory `/usr/src/linux-2.5.68'
/usr/bin/make    \
                                 ARCH=i386  dep
make[2]: Entering directory `/usr/src/linux-2.5.68'
*** Warning: make dep is unnecessary now.
make[2]: Leaving directory `/usr/src/linux-2.5.68'
make[1]: Leaving directory `/usr/src/linux-2.5.68'
/usr/bin/make    \
                                 ARCH=i386 clean
make[1]: Entering directory `/usr/src/linux-2.5.68'
/usr/bin/make -f scripts/Makefile.clean obj=arch/i386/boot
/usr/bin/make -f scripts/Makefile.clean obj=arch/i386/boot/compressed
/usr/bin/make -f scripts/Makefile.clean obj=arch/i386/kernel
/usr/bin/make -f scripts/Makefile.clean obj=arch/i386/kernel/acpi
/usr/bin/make -f scripts/Makefile.clean obj=arch/i386/kernel/cpu
/usr/bin/make -f scripts/Makefile.clean obj=arch/i386/kernel/cpu/cpufreq
/usr/bin/make -f scripts/Makefile.clean obj=arch/i386/kernel/cpu/mcheck
/usr/bin/make -f scripts/Makefile.clean obj=arch/i386/kernel/cpu/mtrr
/usr/bin/make -f scripts/Makefile.clean obj=arch/i386/kernel/timers
/usr/bin/make -f scripts/Makefile.clean obj=arch/i386/lib
/usr/bin/make -f scripts/Makefile.clean obj=arch/i386/mach-default
/usr/bin/make -f scripts/Makefile.clean obj=arch/i386/mach-generic
scripts/Makefile.clean:10: arch/i386/mach-generic/Makefile: No such file or 
directory
make[2]: *** No rule to make target `arch/i386/mach-generic/Makefile'.  Stop.
make[1]: *** [_clean_arch/i386/mach-generic] Error 2
make[1]: Leaving directory `/usr/src/linux-2.5.68'
make: *** [stamp-kernel-configure] Error 2

I know the personal helpdesk stuff, but I seriously suspect there's an issue 
someone else might also run into.

gcc version 2.95.4 20011002 (Debian prerelease)

The patch was downloaded today (1st of May) afternoon (EEST) from:
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.5/2.5.68/2.5.68-mm3/

-Kimmo Sundqvist

Re: 2.5.68-mm3 and a simple mistake

[Kimmo Sundqvist]

On Thursday 01 May 2003 18:41, Andi Kleen wrote:

> Kimmo Sundqvist <rabbit80@mbnet.fi> writes:

> > /usr/bin/make -f scripts/Makefile.clean obj=arch/i386/mach-default
> > /usr/bin/make -f scripts/Makefile.clean obj=arch/i386/mach-generic
> > scripts/Makefile.clean:10: arch/i386/mach-generic/Makefile: No such file
> > or directory
> > make[2]: *** No rule to make target `arch/i386/mach-generic/Makefile'. 
> > Stop. make[1]: *** [_clean_arch/i386/mach-generic] Error 2
> > make[1]: Leaving directory `/usr/src/linux-2.5.68'
> > make: *** [stamp-kernel-configure] Error 2

> Most likely you need to apply this patch. 

This is funny.  Patching with "patch -p0 < 2.5.68-mm3" caused all the patched 
files to appear in /usr/src/25  They also disappeared from 
/usr/src/linux-2.5.68

I did "cp -a /usr/src/25/* /usr/src/linux-2.5.68/" and there was no error at 
first, but the compile failed with:

gcc -Wp,-MD,net/core/.netfilter.o.d -D__KERNEL__ -Iinclude -Wall 
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -pipe 
-mpreferred-stack-boundary=2 -march=i686 -Iinclude/asm-i386/mach-default 
-fomit-frame-pointer -nostdinc -iwithprefix include    
-DKBUILD_BASENAME=netfilter -DKBUILD_MODNAME=netfilter -c -o 
net/core/netfilter.o net/core/netfilter.c
net/core/netfilter.c: In function `nf_reinject':
net/core/netfilter.c:559: `i' undeclared (first use in this function)
net/core/netfilter.c:559: (Each undeclared identifier is reported only once
net/core/netfilter.c:559: for each function it appears in.)
net/core/netfilter.c:559: warning: left-hand operand of comma expression has 
no effect
net/core/netfilter.c:559: warning: left-hand operand of comma expression has 
no effect
make[3]: *** [net/core/netfilter.o] Error 1
make[2]: *** [net/core] Error 2
make[1]: *** [net] Error 2
make[1]: Leaving directory `/usr/src/linux-2.5.68'
make: *** [stamp-build] Error 2

Still I can't understand what is the intended way of doing this.  I will try 
n+1 ways and stop to think now and then, but if someone has an easy way to do 
this, I haven't seen it.

-Kimmo S.

Re: 2.5.68-mm3 and a simple mistake

[Sam Ravnborg]

On Thu, May 01, 2003 at 05:41:05PM +0200, Andi Kleen wrote:
> +
> +EXTRA_CFLAGS	+= -I../kernel

This assignment is not needed AFAICS.
Needs to be removed from a couple of i386 Makefiles, which I will do soon.

	Sam

Re: 2.5.68-mm3 and a simple mistake

[Andi Kleen]

Kimmo Sundqvist <rabbit80@mbnet.fi> writes:

> /usr/bin/make -f scripts/Makefile.clean obj=arch/i386/mach-default
> /usr/bin/make -f scripts/Makefile.clean obj=arch/i386/mach-generic
> scripts/Makefile.clean:10: arch/i386/mach-generic/Makefile: No such file or 
> directory
> make[2]: *** No rule to make target `arch/i386/mach-generic/Makefile'.  Stop.
> make[1]: *** [_clean_arch/i386/mach-generic] Error 2
> make[1]: Leaving directory `/usr/src/linux-2.5.68'
> make: *** [stamp-kernel-configure] Error 2

Most likely you need to apply this patch. It was in the original
subarch patch, but may be gotten lost somewhere.
Hopefully not more is missing.

diff -u linux-apic/arch/i386/mach-generic/Makefile-o linux-apic/arch/i386/mach-generic/Makefile
--- linux-apic/arch/i386/mach-generic/Makefile-o	2003-04-27 02:45:25.000000000 +0200
+++ linux-apic/arch/i386/mach-generic/Makefile	2003-04-27 02:45:25.000000000 +0200
@@ -0,0 +1,9 @@
+#
+# Makefile for the generic architecture
+#
+
+EXTRA_CFLAGS	+= -I../kernel
+
+obj-y				:= probe.o summit.o bigsmp.o default.o
+
+

-Andi