From: William Lee Irwin III <wli@holomorphy.com>
To: Andrew Morton <akpm@digeo.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: 2.5.68-mm4
Date: Fri, 2 May 2003 06:18:57 -0700 [thread overview]
Message-ID: <20030502131857.GH8978@holomorphy.com> (raw)
In-Reply-To: <20030502020149.1ec3e54f.akpm@digeo.com>
On Fri, May 02, 2003 at 02:01:49AM -0700, Andrew Morton wrote:
> +dont-set-kernel-pgd-on-PAE.patch
> little ia32 optimisation/cleanup
It looks like no one listened to my commentary on the set_pgd() patch.
Remove pointless #ifdef, pointless set_pgd(), and a mysterious line
full of nothing but whitespace after the #endif, and update commentary.
-- wli
$ diffstat ../patches/mm4-2.5.68-2
fault.c | 12 ++++--------
1 files changed, 4 insertions(+), 8 deletions(-)
diff -urpN mm4-2.5.68-1/arch/i386/mm/fault.c mm4-2.5.68-2/arch/i386/mm/fault.c
--- mm4-2.5.68-1/arch/i386/mm/fault.c 2003-05-02 05:32:27.000000000 -0700
+++ mm4-2.5.68-2/arch/i386/mm/fault.c 2003-05-02 05:54:14.000000000 -0700
@@ -333,16 +333,12 @@ vmalloc_fault:
if (!pgd_present(*pgd_k))
goto no_context;
+
/*
- * kernel pmd pages are shared among all processes
- * with PAE on. Since vmalloc pages are always
- * in the kernel area, this will always be a
- * waste with PAE on.
+ * set_pgd(pgd, *pgd_k); here would be useless on PAE
+ * and redundant with the set_pmd() on non-PAE.
*/
-#ifndef CONFIG_X86_PAE
- set_pgd(pgd, *pgd_k);
-#endif
-
+
pmd = pmd_offset(pgd, address);
pmd_k = pmd_offset(pgd_k, address);
if (!pmd_present(*pmd_k))
next prev parent reply other threads:[~2003-05-02 13:06 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-02 9:01 2.5.68-mm4 Andrew Morton
2003-05-02 13:18 ` William Lee Irwin III [this message]
2003-05-02 16:47 ` 2.5.68-mm4 Dave Hansen
2003-05-02 14:45 ` 2.5.68-mm4 Steven Cole
2003-05-02 15:00 ` 2.5.68-mm4 Steven Cole
2003-05-02 15:35 ` 2.5.68-mm4 Anton Blanchard
2003-05-03 14:12 ` 2.5.68-mm4 Eric W. Biederman
2003-05-02 16:54 ` 2.5.68-mm4 Martin J. Bligh
2003-05-02 20:04 ` 2.5.68-mm4 Steven Cole
2003-05-02 20:34 ` 2.5.68-mm4 Andrew Morton
2003-05-02 20:49 ` 2.5.68-mm4 Steven Cole
2003-05-02 21:01 ` 2.5.68-mm4 Steven Cole
2003-05-02 21:05 ` 2.5.68-mm4 Andrew Morton
2003-05-02 21:20 ` 2.5.68-mm4 Steven Cole
2003-05-02 21:49 ` 2.5.68-mm4 Andy Pfiffer
2003-05-02 22:00 ` 2.5.68-mm4 Steven Cole
2003-05-02 23:22 ` 2.5.68-mm4 Matt Bernstein
2003-05-02 23:41 ` 2.5.68-mm4 Andrew Morton
2003-05-03 2:53 ` 2.5.68-mm4 Andi Kleen
2003-05-03 7:08 ` 2.5.68-mm4 Matt Bernstein
[not found] ` <Pine.LNX.4.55.0305061511020.3237@r2-pc.dcs.qmul.ac.uk>
2003-05-06 14:35 ` 2.5.68-mm4 Andi Kleen
2003-05-06 15:50 ` 2.5.68-mm4 Matt Bernstein
2003-05-07 10:27 ` 2.5.68-mm4 Matt Bernstein
2003-05-07 12:35 ` 2.5.68-mm4 Andi Kleen
2003-05-07 15:45 ` 2.5.68-mm4 Matt Bernstein
2003-05-03 3:14 ` 2.5.68-mm4 Andi Kleen
2003-05-03 13:51 ` 2.5.68-mm4 Diego Calleja García
2003-05-03 1:14 ` 2.5.68-mm4 Herbert Xu
2003-05-05 3:46 ` 2.5.68-mm4 && kexec Eric W. Biederman
2003-05-02 19:58 2.5.68-mm4 J. Hidding
2003-05-03 11:52 2.5.68-mm4 cb-lkml
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030502131857.GH8978@holomorphy.com \
--to=wli@holomorphy.com \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).