linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* DECNET in latest BK
@ 2003-05-03 17:59 Larry McVoy
  2003-05-03 18:38 ` David S. Miller
  0 siblings, 1 reply; 5+ messages in thread
From: Larry McVoy @ 2003-05-03 17:59 UTC (permalink / raw)
  To: linux-kernel

Doesn't build, I didn't config it out by mistake.  Dunno if anyone uses
decnet.

net/decnet/dn_route.c: In function `dn_route_output_slow':
net/decnet/dn_route.c:1058: `flp' undeclared (first use in this function)
net/decnet/dn_route.c:1058: (Each undeclared identifier is reported only once
net/decnet/dn_route.c:1058: for each function it appears in.)
net/decnet/dn_route.c: In function `dn_route_input_slow':
net/decnet/dn_route.c:1183: structure has no member named `fwmark'
make[2]: *** [net/decnet/dn_route.o] Error 1
make[1]: *** [net/decnet] Error 2
make: *** [net] Error 2

-- 
---
Larry McVoy              lm at bitmover.com          http://www.bitmover.com/lm

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: DECNET in latest BK
  2003-05-03 17:59 DECNET in latest BK Larry McVoy
@ 2003-05-03 18:38 ` David S. Miller
  2003-05-03 18:39   ` Francois Romieu
  0 siblings, 1 reply; 5+ messages in thread
From: David S. Miller @ 2003-05-03 18:38 UTC (permalink / raw)
  To: Larry McVoy; +Cc: linux-kernel

On Sat, 2003-05-03 at 10:59, Larry McVoy wrote:
> Doesn't build, I didn't config it out by mistake.  Dunno if anyone uses
> decnet.
> 
> net/decnet/dn_route.c: In function `dn_route_output_slow':
> net/decnet/dn_route.c:1058: `flp' undeclared (first use in this function)

Turn off CONFIG_DECNET_ROUTE_FWMARK, aparently even the maintainer
doesn't even enable this option :-)

-- 
David S. Miller <davem@redhat.com>
D

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: DECNET in latest BK
  2003-05-03 18:38 ` David S. Miller
@ 2003-05-03 18:39   ` Francois Romieu
  2003-05-04 12:09     ` David S. Miller
  2003-05-04 18:39     ` Steven Whitehouse
  0 siblings, 2 replies; 5+ messages in thread
From: Francois Romieu @ 2003-05-03 18:39 UTC (permalink / raw)
  To: David S. Miller; +Cc: linux-kernel

David S. Miller <davem@redhat.com> :
[...]
> Turn off CONFIG_DECNET_ROUTE_FWMARK, aparently even the maintainer
> doesn't even enable this option :-)

Does the attached patch make sense ?

 net/decnet/dn_route.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff -puN net/decnet/dn_route.c~decnet-compile-fix net/decnet/dn_route.c
--- linux-2.5.68-1.1118.1.6-to-1.1192/net/decnet/dn_route.c~decnet-compile-fix	Fri May  2 23:19:48 2003
+++ linux-2.5.68-1.1118.1.6-to-1.1192-fr/net/decnet/dn_route.c	Fri May  2 23:19:48 2003
@@ -1055,7 +1055,7 @@ make_route:
 	rt->fl.oif        = oldflp->oif;
 	rt->fl.iif        = 0;
 #ifdef CONFIG_DECNET_ROUTE_FWMARK
-	rt->fl.fld_fwmark = flp->fld_fwmark;
+	rt->fl.fld_fwmark = oldflp->fld_fwmark;
 #endif
 
 	rt->rt_saddr      = fl.fld_src;
@@ -1180,7 +1180,7 @@ static int dn_route_input_slow(struct sk
 				       .saddr = cb->src,
 				       .scope = RT_SCOPE_UNIVERSE,
 #ifdef CONFIG_DECNET_ROUTE_FWMARK
-				       .fwmark = skb->fwmark
+				       .fwmark = skb->nfmark
 #endif
 				    } },
 			    .iif = skb->dev->ifindex };


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: DECNET in latest BK
  2003-05-03 18:39   ` Francois Romieu
@ 2003-05-04 12:09     ` David S. Miller
  2003-05-04 18:39     ` Steven Whitehouse
  1 sibling, 0 replies; 5+ messages in thread
From: David S. Miller @ 2003-05-04 12:09 UTC (permalink / raw)
  To: romieu; +Cc: linux-kernel

   From: Francois Romieu <romieu@fr.zoreil.com>
   Date: Sat, 3 May 2003 20:39:08 +0200

   David S. Miller <davem@redhat.com> :
   [...]
   > Turn off CONFIG_DECNET_ROUTE_FWMARK, aparently even the maintainer
   > doesn't even enable this option :-)
   
   Does the attached patch make sense ?

Looks good, applied.

Thanks.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: DECNET in latest BK
  2003-05-03 18:39   ` Francois Romieu
  2003-05-04 12:09     ` David S. Miller
@ 2003-05-04 18:39     ` Steven Whitehouse
  1 sibling, 0 replies; 5+ messages in thread
From: Steven Whitehouse @ 2003-05-04 18:39 UTC (permalink / raw)
  To: Francois Romieu; +Cc: David S. Miller, linux-kernel

Hi,

> 
> David S. Miller <davem@redhat.com> :
> [...]
> > Turn off CONFIG_DECNET_ROUTE_FWMARK, aparently even the maintainer
> > doesn't even enable this option :-)
> 
> Does the attached patch make sense ?
>
Yes, I can confirm thats the right fix. I was a bit busy last week and my fix
didn't make it in time, but I'm back now and so the rest of my pending DECnet
patches will be submitted shortly. Thanks for the patch,

Steve.


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2003-05-04 18:36 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-05-03 17:59 DECNET in latest BK Larry McVoy
2003-05-03 18:38 ` David S. Miller
2003-05-03 18:39   ` Francois Romieu
2003-05-04 12:09     ` David S. Miller
2003-05-04 18:39     ` Steven Whitehouse

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).