From: Andrew Morton <akpm@digeo.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC] how to fix is_local_disk()?
Date: Sun, 4 May 2003 00:30:21 -0700 [thread overview]
Message-ID: <20030504003021.077e8819.akpm@digeo.com> (raw)
In-Reply-To: <20030504090003.A7285@lst.de>
Christoph Hellwig <hch@lst.de> wrote:
>
> In drivers/char/sysrq.c we have this nice piece of code:
>
Suggest you chainsaw the whole lot and simply do a wakeup_bdflush(0) from
interrupt context.
The only functional change I can see with this is that it could cause pdflush
to get stuck if there are dead NFS/SMBFS/etc mounts.
But if that happens, we need to fix it anyway. Those filesystems should
avoid getting stuck if called with writeback_control.sync_mode != WB_SYNC_ALL,
especially if current_is_pdflush() returns true.
next prev parent reply other threads:[~2003-05-04 7:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-04 7:00 [RFC] how to fix is_local_disk()? Christoph Hellwig
2003-05-04 7:30 ` Andrew Morton [this message]
2003-05-04 7:53 ` Christoph Hellwig
2003-05-04 8:00 ` Andrew Morton
2003-05-04 17:10 ` Christoph Hellwig
2003-05-04 21:05 ` Andrew Morton
2003-05-05 7:41 ` viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030504003021.077e8819.akpm@digeo.com \
--to=akpm@digeo.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).