linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: David Ford <david+powerix@blue-labs.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	apcupsd-devel@apcupsd.org
Subject: Re: APC USB ups, Back-UPS ES series, 2.5.68
Date: Mon, 5 May 2003 21:25:52 -0700	[thread overview]
Message-ID: <20030506042552.GA5612@kroah.com> (raw)
In-Reply-To: <3EB7130D.6080802@blue-labs.org>

On Mon, May 05, 2003 at 09:42:37PM -0400, David Ford wrote:
> I haven't had time to look at it and try to debug it.  The 96 v.s. 192 
> minor look like it's exactly 128 too high.  Perhaps it's a simple fix?

Can you try this patch and let me know if it works or not?

thanks,

greg k-h


--- a/drivers/usb/input/hiddev.c	Sun May  4 23:49:54 2003
+++ b/drivers/usb/input/hiddev.c	Mon May  5 21:23:42 2003
@@ -714,9 +714,9 @@
 	hiddev->hid = hid;
 	hiddev->exist = 1;
 
-	sprintf(devfs_name, "usb/hid/hiddev%d", minor);
+	sprintf(devfs_name, "usb/hid/hiddev%d", minor - HIDDEV_MINOR_BASE);
 	devfs_register(NULL, devfs_name, 0,
-		USB_MAJOR, minor + HIDDEV_MINOR_BASE,
+		USB_MAJOR, minor,
 		S_IFCHR | S_IRUGO | S_IWUSR, &hiddev_fops, NULL);
 	hid->minor = minor;
 	hid->hiddev = hiddev;

      reply	other threads:[~2003-05-06  4:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-03  3:04 APC USB ups, Back-UPS ES series, 2.5.68 David Ford
2003-05-03  6:36 ` Greg KH
2003-05-03 10:05   ` David Ford
2003-05-06  1:42     ` David Ford
2003-05-06  4:25       ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030506042552.GA5612@kroah.com \
    --to=greg@kroah.com \
    --cc=apcupsd-devel@apcupsd.org \
    --cc=david+powerix@blue-labs.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).