From: Jens Axboe <axboe@suse.de>
To: David Woodhouse <dwmw2@infradead.org>
Cc: "Nicolas Pitre" <nico@cam.org>,
"Alan Cox" <alan@lxorguk.ukuu.org.uk>,
"Russell King" <rmk@arm.linux.org.uk>,
"Jörn Engel" <joern@wohnheim.fh-wedel.de>,
"Marcus Meissner" <meissner@suse.de>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Only use MSDOS-Partitions by default on X86
Date: Wed, 7 May 2003 09:43:12 +0200 [thread overview]
Message-ID: <20030507074312.GA483@suse.de> (raw)
In-Reply-To: <1052293277.10965.14.camel@imladris.demon.co.uk>
On Wed, May 07 2003, David Woodhouse wrote:
> On Wed, 2003-05-07 at 08:22, Jens Axboe wrote:
> > > That's a little short of what I was intending. Ideally we stick 'struct
> > > request', 'struct buffer_head' and 'struct bio' inside #ifdef
> > > CONFIG_BLK_DEV, then kill all the dead code which uses them.
> >
> > struct request can be a goner with my patch, the others not really.
> > request is really a block private property, so it's easy to kill off.
> > You are going for the really minimal approach, basically ruling out lots
> > of filesystems and requiring major surgery all around. While I can see
> > that make sense for an embedded kernel, I'm having a hard time
> > envisioning this as something mergable :-)
>
> Last time I looked, it wasn't that bad until I got mired in VM code.
> I haven't looked at that since we got CONFIG_SWAP, but I'm fairly sure
> the VM bits will be a lot nicer now too.
I'll let you deal with that, my head is spinning from just thinking
about it :)
> > > mtdblock.c cleanup noted with interest -- I'll play with that shortly;
> > > thanks. Note that you don't actually need flash hardware, you can load
> > > the 'mtdram' device which fakes it with vmalloc-backed storage instead.
> > > Not too useful for powerfail-testing but for mounting something like
> > > ext2 on mtdblock on mtdram it's fine.
> >
> > I'm attaching an updated version, I don't think it's safe to use atomic
> > kmaps across the do_cached_read/write.
>
> It's not -- the flash read/write/erase functions may sleep.
Thought so.
> > Also, I want bio_endio() to increment the sector position of the bio as
> > well. Makes for a nicer api, and the sector var in mtdblock would then
> > be killable.
>
> OK. Let me know when you're done and I'll fix up FTL and NFTL
> accordingly too.
The only change to the patch attached in the previous mail is just to
drop the sector_t sector and use bio->bi_sector throughout the function.
So nothing major.
--
Jens Axboe
next prev parent reply other threads:[~2003-05-07 7:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20030505210811.GC7049@wohnheim.fh-wedel.de.suse.lists.linux.kernel>
[not found] ` <1052218090.28792.15.camel@dhcp22.swansea.linux.org.uk.suse.lists.linux.kernel>
[not found] ` <20030506120939.GB15261@wohnheim.fh-wedel.de.suse.lists.linux.kernel>
2003-05-06 12:28 ` [PATCH] Only use MSDOS-Partitions by default on X86 Marcus Meissner
2003-05-06 12:42 ` Jörn Engel
2003-05-06 14:03 ` Russell King
2003-05-06 15:32 ` Jörn Engel
2003-05-06 17:13 ` Russell King
2003-05-06 17:23 ` Nicolas Pitre
2003-05-06 17:26 ` Alan Cox
2003-05-06 18:30 ` Jens Axboe
2003-05-06 18:42 ` Nicolas Pitre
2003-05-06 18:49 ` Jens Axboe
2003-05-06 19:10 ` Nicolas Pitre
2003-05-06 19:20 ` Jens Axboe
2003-05-06 19:54 ` Jens Axboe
2003-05-06 21:01 ` David Woodhouse
2003-05-07 7:22 ` Jens Axboe
2003-05-07 7:41 ` David Woodhouse
2003-05-07 7:43 ` Jens Axboe [this message]
2003-05-06 17:42 ` [PATCH] Only use MS-DOS-Partitions " Riley Williams
2003-05-05 21:08 [PATCH] Only use MSDOS-Partitions " Jörn Engel
2003-05-06 10:48 ` Alan Cox
2003-05-06 12:09 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030507074312.GA483@suse.de \
--to=axboe@suse.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dwmw2@infradead.org \
--cc=joern@wohnheim.fh-wedel.de \
--cc=linux-kernel@vger.kernel.org \
--cc=meissner@suse.de \
--cc=nico@cam.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).