From: viro@parcelfarce.linux.theplanet.co.uk
To: Stephen Smalley <sds@epoch.ncsc.mil>
Cc: Linus Torvalds <torvalds@transmeta.com>,
Andrew Morton <akpm@digeo.com>,
lkml <linux-kernel@vger.kernel.org>,
Jan Harkes <jaharkes@cs.cmu.edu>,
lsm <linux-security-module@wirex.com>
Subject: Re: [PATCH] Process Attribute API for Security Modules 2.5.69
Date: Wed, 7 May 2003 11:50:38 +0100 [thread overview]
Message-ID: <20030507105038.GN10374@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <1052237601.1377.991.camel@moss-huskers.epoch.ncsc.mil>
On Tue, May 06, 2003 at 12:13:25PM -0400, Stephen Smalley wrote:
> +static int proc_attr_readdir(struct file * filp,
> + void * dirent, filldir_t filldir)
Umm... How about having it merged with proc_base_readdir()? I.e.
have both call the common helper. Ditto for lookups.
Other than that (and missing check for copy_to_user() return value in
->read()) I don't see any problems here.
next prev parent reply other threads:[~2003-05-07 10:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-06 16:13 [PATCH] Process Attribute API for Security Modules 2.5.69 Stephen Smalley
2003-05-06 21:01 ` Andrew Morton
2003-05-07 10:50 ` viro [this message]
2003-05-07 15:02 ` Stephen Smalley
2003-05-08 12:12 ` Andreas Gruenbacher
2003-05-08 13:19 ` viro
2003-05-16 20:08 ` Stephen Smalley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030507105038.GN10374@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=akpm@digeo.com \
--cc=jaharkes@cs.cmu.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@wirex.com \
--cc=sds@epoch.ncsc.mil \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).