From: norbert_wolff@t-online.de (Norbert Wolff)
To: lkml <linux-kernel@vger.kernel.org>
Subject: Bogus Warning in ppp_generic.c
Date: Fri, 9 May 2003 10:24:01 +0200 [thread overview]
Message-ID: <20030509102401.3534d179.norbert_wolff@t-online.de> (raw)
Hi !
If devfs is not configured, devfs_mk_cdev returns 0.
The ppp_generic-Driver reports a bogus Warning in this case.
Fix below.
Regards,
Norbert
--- ppp_generic.c.orig 2003-05-09 09:16:56.%N +0200
+++ ppp_generic.c 2003-05-09 10:09:19.%N +0200
@@ -784,10 +784,13 @@ int __init ppp_init(void)
printk(KERN_INFO "PPP generic driver version " PPP_VERSION "\n");
err = register_chrdev(PPP_MAJOR, "ppp", &ppp_device_fops);
+
+#ifdef CONFIG_DEVFS_FS
if (!err) {
err = devfs_mk_cdev(MKDEV(PPP_MAJOR, 0),
S_IFCHR|S_IRUSR|S_IWUSR, "ppp");
}
+#endif
if (!err)
printk(KERN_ERR "failed to register PPP device (%d)\n", err);
--
Norbert Wolff
OpenPGP-Key:
http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xF13BD6F6
next reply other threads:[~2003-05-09 8:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-09 8:24 Norbert Wolff [this message]
2003-05-09 8:32 ` Bogus Warning in ppp_generic.c Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030509102401.3534d179.norbert_wolff@t-online.de \
--to=norbert_wolff@t-online.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).