* [2.5 patch] remove all #include <blk.h>'s
@ 2003-05-10 16:30 Adrian Bunk
2003-05-10 16:57 ` Adrian Bunk
2003-05-11 13:57 ` Jens Axboe
0 siblings, 2 replies; 9+ messages in thread
From: Adrian Bunk @ 2003-05-10 16:30 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: torvalds, linux-kernel
The attached patch (gzipped due to 100 kB linux-kernel limit) removes
all #include <blk.h>'s for 2.5 and blk.h does now #error. If people
want their drivers to run unmodified under 2.4 it might be necessary to
do a
#if LINUX_VERSION_CODE < KERNEL_VERSION(2,5,70)
#include <linux/blk.h>
#endif
I've tested the compilation in 2.5.69-bk4 with a .config that tries to
compile as much drivers as possible.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [2.5 patch] remove all #include <blk.h>'s
2003-05-10 16:30 [2.5 patch] remove all #include <blk.h>'s Adrian Bunk
@ 2003-05-10 16:57 ` Adrian Bunk
2003-05-11 13:57 ` Jens Axboe
1 sibling, 0 replies; 9+ messages in thread
From: Adrian Bunk @ 2003-05-10 16:57 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: torvalds, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 802 bytes --]
On Sat, May 10, 2003 at 06:30:43PM +0200, Adrian Bunk wrote:
> The attached patch (gzipped due to 100 kB linux-kernel limit) removes
> all #include <blk.h>'s for 2.5 and blk.h does now #error. If people
> want their drivers to run unmodified under 2.4 it might be necessary to
> do a
> #if LINUX_VERSION_CODE < KERNEL_VERSION(2,5,70)
> #include <linux/blk.h>
> #endif
>
> I've tested the compilation in 2.5.69-bk4 with a .config that tries to
> compile as much drivers as possible.
>
> cu
> Adrian
Ups, forgot to attach the file...
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
[-- Attachment #2: patch-cleanup-blk.gz --]
[-- Type: application/x-gunzip, Size: 11173 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [2.5 patch] remove all #include <blk.h>'s
2003-05-10 16:30 [2.5 patch] remove all #include <blk.h>'s Adrian Bunk
2003-05-10 16:57 ` Adrian Bunk
@ 2003-05-11 13:57 ` Jens Axboe
2003-05-11 14:45 ` Adrian Bunk
1 sibling, 1 reply; 9+ messages in thread
From: Jens Axboe @ 2003-05-11 13:57 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Christoph Hellwig, torvalds, linux-kernel
On Sat, May 10 2003, Adrian Bunk wrote:
> all #include <blk.h>'s for 2.5 and blk.h does now #error. If people
I think that's _really_ stupid. Make it a warning ala
#warning blk.h is deprecated, use blkdev.h
like we did with malloc.h in 2.4.
> want their drivers to run unmodified under 2.4 it might be necessary to
> do a
> #if LINUX_VERSION_CODE < KERNEL_VERSION(2,5,70)
> #include <linux/blk.h>
> #endif
That is horrible.
--
Jens Axboe
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [2.5 patch] remove all #include <blk.h>'s
2003-05-11 13:57 ` Jens Axboe
@ 2003-05-11 14:45 ` Adrian Bunk
2003-05-11 14:47 ` Jens Axboe
0 siblings, 1 reply; 9+ messages in thread
From: Adrian Bunk @ 2003-05-11 14:45 UTC (permalink / raw)
To: Jens Axboe; +Cc: Christoph Hellwig, torvalds, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 626 bytes --]
On Sun, May 11, 2003 at 03:57:36PM +0200, Jens Axboe wrote:
> On Sat, May 10 2003, Adrian Bunk wrote:
> > all #include <blk.h>'s for 2.5 and blk.h does now #error. If people
>
> I think that's _really_ stupid. Make it a warning ala
>
> #warning blk.h is deprecated, use blkdev.h
>
> like we did with malloc.h in 2.4.
>...
Changed patch is attached.
> Jens Axboe
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
[-- Attachment #2: patch-cleanup-blk-2.gz --]
[-- Type: application/x-gunzip, Size: 11182 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [2.5 patch] remove all #include <blk.h>'s
2003-05-11 14:45 ` Adrian Bunk
@ 2003-05-11 14:47 ` Jens Axboe
0 siblings, 0 replies; 9+ messages in thread
From: Jens Axboe @ 2003-05-11 14:47 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Christoph Hellwig, torvalds, linux-kernel
On Sun, May 11 2003, Adrian Bunk wrote:
> On Sun, May 11, 2003 at 03:57:36PM +0200, Jens Axboe wrote:
> > On Sat, May 10 2003, Adrian Bunk wrote:
> > > all #include <blk.h>'s for 2.5 and blk.h does now #error. If people
> >
> > I think that's _really_ stupid. Make it a warning ala
> >
> > #warning blk.h is deprecated, use blkdev.h
> >
> > like we did with malloc.h in 2.4.
> >...
>
> Changed patch is attached.
Cool thanks, I greatly prefer this variant. And thanks for doing this
work, btw.
--
Jens Axboe
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [2.5 patch] remove all #include <blk.h>'s
2003-07-15 15:34 Adrian Bunk
@ 2003-07-15 19:39 ` Andrew Morton
0 siblings, 0 replies; 9+ messages in thread
From: Andrew Morton @ 2003-07-15 19:39 UTC (permalink / raw)
To: Adrian Bunk; +Cc: torvalds, hch, linux-kernel, akpm
Adrian Bunk <bunk@fs.tum.de> wrote:
>
> the attached patch against 2.6.0-test1 (gzip'ed due to it's size) causes
> blk.h to print a warning and removes all uses of blk.h. I've tested the
> compilation in 2.6.0-test1 with a .config that tries to compile as many
> drivers as possible.
>
> Please either apply it or send a short note that you don't want to apply
> it.
"cleanups" are being vigorously ignored now. I'd be inclined to let this
one go, thanks.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [2.5 patch] remove all #include <blk.h>'s
@ 2003-07-15 15:34 Adrian Bunk
2003-07-15 19:39 ` Andrew Morton
0 siblings, 1 reply; 9+ messages in thread
From: Adrian Bunk @ 2003-07-15 15:34 UTC (permalink / raw)
To: Linus Torvalds, Christoph Hellwig; +Cc: linux-kernel, Andrew Morton
[-- Attachment #1: Type: text/plain, Size: 589 bytes --]
Hi Linus,
the attached patch against 2.6.0-test1 (gzip'ed due to it's size) causes
blk.h to print a warning and removes all uses of blk.h. I've tested the
compilation in 2.6.0-test1 with a .config that tries to compile as many
drivers as possible.
Please either apply it or send a short note that you don't want to apply
it.
TIA
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
[-- Attachment #2: patch-cleanup-blk-5.gz --]
[-- Type: application/x-gunzip, Size: 11629 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* [2.5 patch] remove all #include <blk.h>'s
@ 2003-07-03 23:22 Adrian Bunk
0 siblings, 0 replies; 9+ messages in thread
From: Adrian Bunk @ 2003-07-03 23:22 UTC (permalink / raw)
To: Linus Torvalds, Christoph Hellwig; +Cc: linux-kernel, Andrew Morton
[-- Attachment #1: Type: text/plain, Size: 579 bytes --]
Hi Linus,
the attached patch against 2.5.74 (gzip'ed due to it's size) causes
blk.h to print a warning and removes all uses of blk.h. I've tested the
compilation in 2.5.74 with a .config that tries to compile as many
drivers as possible.
Please either apply it or send a short note that you don't want to apply
it.
TIA
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
[-- Attachment #2: patch-cleanup-blk-4.gz --]
[-- Type: application/x-gunzip, Size: 11534 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* [2.5 patch] remove all #include <blk.h>'s
@ 2003-05-27 22:06 Adrian Bunk
0 siblings, 0 replies; 9+ messages in thread
From: Adrian Bunk @ 2003-05-27 22:06 UTC (permalink / raw)
To: Linus Torvalds, Christoph Hellwig; +Cc: linux-kernel, Andrew Morton
[-- Attachment #1: Type: text/plain, Size: 576 bytes --]
Hi Linus,
the attached patch against 2.5.70 (gzip'ed due to it's size) causes
blk.h to print a warning and removes all uses of blk.h. I've tested the
compilation in 2.5.70 with a .config that tries to compile as much
drivers as possible.
Please either apply it or send a short note that you don't want to apply
it.
TIA
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
[-- Attachment #2: patch-cleanup-blk-3.gz --]
[-- Type: application/x-gunzip, Size: 11176 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2003-07-15 19:32 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-05-10 16:30 [2.5 patch] remove all #include <blk.h>'s Adrian Bunk
2003-05-10 16:57 ` Adrian Bunk
2003-05-11 13:57 ` Jens Axboe
2003-05-11 14:45 ` Adrian Bunk
2003-05-11 14:47 ` Jens Axboe
2003-05-27 22:06 Adrian Bunk
2003-07-03 23:22 Adrian Bunk
2003-07-15 15:34 Adrian Bunk
2003-07-15 19:39 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).