linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Parse new-style boot parameters just before initcalls
Date: Mon, 12 May 2003 12:05:48 +1000	[thread overview]
Message-ID: <20030512040100.C7B972C0D7@lists.samba.org> (raw)
In-Reply-To: Your message of "Sat, 10 May 2003 18:19:36 +0200." <Pine.SOL.4.30.0305101735410.20755-100000@mion.elka.pw.edu.pl>

In message <Pine.SOL.4.30.0305101735410.20755-100000@mion.elka.pw.edu.pl> you w
rite:
> 
> Hi,
> 
> I've redone this patch. I've tested it and works okay for me.
> It is as minimal as possible and I hope it can go in 2.5 soon.

Only one request, that you push this slightly more, and make
setup_arch() call parse_early_args().  Does that break something?

That way the arch-specific parsing in setup_arch() can be converted to
__setup (but doesn't need to be: archs can take their time).

ie. we already have two-stage parsing, it'd be nice not to make it
three.

Minor nitpick:

> @@ -241,7 +279,7 @@ static int __init unknown_bootoption(cha
>  		val[-1] = '=';
> 
>  	/* Handle obsolete-style parameters */
> -	if (obsolete_checksetup(param))
> +	if (obsolete_test_checksetup(param))
>  		return 0;
> 

Change comment to /* Ignore early params: already done in
parse_early_args */ or something, and maybe rename
obsolete_test_checksetup() to is_early_setup().

Thanks!
Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

  parent reply	other threads:[~2003-05-12  3:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-10 16:19 [PATCH] Parse new-style boot parameters just before initcalls Bartlomiej Zolnierkiewicz
2003-05-10 16:25 ` [PATCH] Switch ide parameters to new-style and make them unique Bartlomiej Zolnierkiewicz
2003-05-11 14:59   ` Jeremy Jackson
2003-05-11 15:32     ` Bartlomiej Zolnierkiewicz
2003-05-11 16:35       ` Alan Cox
2003-05-12  1:49       ` Jeremy Jackson
2003-05-12  6:37         ` Rusty Russell
2003-05-12 12:34           ` Bartlomiej Zolnierkiewicz
2003-05-12  2:21     ` Rusty Russell
2003-05-12  2:05 ` Rusty Russell [this message]
2003-05-12 12:05   ` [PATCH] Parse new-style boot parameters just before initcalls Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030512040100.C7B972C0D7@lists.samba.org \
    --to=rusty@rustcorp.com.au \
    --cc=B.Zolnierkiewicz@elka.pw.edu.pl \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).