From: Sam Ravnborg <sam@ravnborg.org>
To: linux-kernel@vger.kernel.org, hch@infradead.org,
gregkh@kroah.com, linux-security-module@wirex.com
Subject: Re: [PATCH] Early init for security modules
Date: Tue, 13 May 2003 20:07:05 +0200 [thread overview]
Message-ID: <20030513180705.GB1170@mars.ravnborg.org> (raw)
In-Reply-To: <20030512200309.C20068@figure1.int.wirex.com>
On Mon, May 12, 2003 at 08:03:09PM -0700, Chris Wright wrote:
>
> --- 1.30/arch/i386/vmlinux.lds.S Tue May 6 06:54:06 2003
> +++ edited/arch/i386/vmlinux.lds.S Mon May 12 16:20:10 2003
> @@ -81,6 +81,9 @@
> __con_initcall_start = .;
> .con_initcall.init : { *(.con_initcall.init) }
> __con_initcall_end = .;
> + __security_initcall_start = .;
> + .security_initcall.init : { *(.security_initcall.init) }
> + __security_initcall_end = .;
I would much prefer to have only:
+ SECURITY_INIT
and moving the common stuff to include/asm-generic/vmlinux.lds.h.
Note that I moved definition of _start and _stop inside brackets.
Doing this makes sure the start address is always correct, independent
of the end address of last section.
Starting a new section will align to member with biggest alignment,
so we may see _start have a wrong value in some cases.
Using SECURITY_INIT will make changes to all architectures
even more trivial.
Sam
===== include/asm-generic/vmlinux.lds.h 1.7 vs edited =====
--- 1.7/include/asm-generic/vmlinux.lds.h Mon Feb 3 22:00:30 2003
+++ edited/include/asm-generic/vmlinux.lds.h Tue May 13 20:02:45 2003
@@ -45,3 +45,9 @@
*(__ksymtab_strings) \
}
+#define SECURITY_INIT \
+ .security_initcall.init : { \
+ __security_initcall_start = .; \
+ *(.security_initcall.init) \
+ __security_initcall_end = .; \
+ }
prev parent reply other threads:[~2003-05-13 17:54 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-13 3:03 [PATCH] Early init for security modules Chris Wright
2003-05-13 3:07 ` Chris Wright
2003-05-13 3:08 ` Chris Wright
2003-05-13 9:03 ` Russell King
2003-05-13 9:20 ` Documentation/linu-logo-HOWTO.txt cosmos
2003-05-13 9:57 ` Documentation/linu-logo-HOWTO.txt Geert Uytterhoeven
2003-05-13 11:25 ` Documentation/linux-logo-HOWTO.txt cosmos
2003-05-13 13:16 ` Documentation/linu-logo-HOWTO.txt Alan Cox
2003-05-13 3:08 ` [PATCH] Early init for security modules Chris Wright
2003-05-13 3:09 ` Chris Wright
2003-05-13 3:09 ` Chris Wright
2003-05-13 5:56 ` David Mosberger
2003-05-13 3:10 ` Chris Wright
2003-05-13 3:10 ` Chris Wright
2003-05-14 0:10 ` Greg Ungerer
2003-05-13 3:11 ` Chris Wright
2003-05-13 3:12 ` Chris Wright
2003-05-13 3:13 ` Chris Wright
2003-05-13 3:13 ` Chris Wright
2003-05-13 4:45 ` Paul Mackerras
2003-05-13 3:13 ` Chris Wright
2003-05-13 3:14 ` Chris Wright
2003-05-13 3:14 ` Chris Wright
2003-05-13 3:15 ` Chris Wright
2003-05-13 5:03 ` Andi Kleen
2003-05-13 5:20 ` Chris Wright
2003-05-13 5:27 ` Christoph Hellwig
2003-05-20 0:57 ` Chris Wright
2003-05-13 5:28 ` Andi Kleen
2003-05-13 6:16 ` Chris Wright
2003-05-13 6:29 ` Andi Kleen
2003-05-13 18:07 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030513180705.GB1170@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=gregkh@kroah.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@wirex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).