From: Andreas Dilger <adilger@clusterfs.com>
To: Andrew Morton <akpm@digeo.com>
Cc: Alex Tomas <bzzz@tmi.comex.ru>,
linux-kernel@vger.kernel.org, ext2-devel@lists.sourceforge.net
Subject: Re: [Ext2-devel] Re: [RFC] probably invalid accounting in jbd
Date: Fri, 23 May 2003 10:02:14 -0600 [thread overview]
Message-ID: <20030523100214.B16920@schatzie.adilger.int> (raw)
In-Reply-To: <20030523012636.1d272586.akpm@digeo.com>; from akpm@digeo.com on Fri, May 23, 2003 at 01:26:36AM -0700
On May 23, 2003 01:26 -0700, Andrew Morton wrote:
> umm, one possible solution to that is to rework the t_outstanding_credits
> logic so that we instead record:
>
> number of buffers attached to the transaction +
> sum of the initial size of all currently-running handles.
>
> as each handle is closed off, we subtract its initial size from the above
> metric. Any buffers which that handle happened to add to the lists would
> have already been accounted for, when they were added.
One other benefit of doing it that way is that having the original handle
size kept in the handle means that you can properly flag errors when a
nested transaction is "started" on an existing handle and the new start
wants more credits than were actually in the handle.
Cheers, Andreas
--
Andreas Dilger
http://sourceforge.net/projects/ext2resize/
http://www-mddsp.enel.ucalgary.ca/People/adilger/
prev parent reply other threads:[~2003-05-23 15:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-18 17:21 [RFC] probably bug in current ext3/jbd Alex Tomas
2003-05-19 20:34 ` [Ext2-devel] " Stephen C. Tweedie
2003-05-20 0:46 ` Alex Tomas
2003-05-19 20:51 ` Stephen C. Tweedie
2003-05-20 0:58 ` Alex Tomas
2003-05-20 16:06 ` Alex Tomas
2003-05-21 16:38 ` Andrew Morton
2003-05-21 20:45 ` Alex Tomas
2003-05-21 16:59 ` Andrew Morton
[not found] ` <m3brxwe2lr.fsf@lexa.home.net>
[not found] ` <20030521103737.52eddeb3.akpm@digeo.com>
[not found] ` <87n0hgc6s6.fsf@gw.home.net>
[not found] ` <20030521105011.2d316baf.akpm@digeo.com>
[not found] ` <87k7ckc5z2.fsf@gw.home.net>
[not found] ` <20030521143140.3aaa86ba.akpm@digeo.com>
2003-05-23 11:08 ` Alex Tomas
2003-05-23 8:49 ` Andrew Morton
2003-05-23 12:49 ` Alex Tomas
2003-05-23 11:20 ` [RFC] probably invalid accounting in jbd Alex Tomas
2003-05-23 8:26 ` Andrew Morton
2003-05-23 16:02 ` Andreas Dilger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030523100214.B16920@schatzie.adilger.int \
--to=adilger@clusterfs.com \
--cc=akpm@digeo.com \
--cc=bzzz@tmi.comex.ru \
--cc=ext2-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).