From: Russell King <rmk@arm.linux.org.uk>
To: "David S. Miller" <davem@redhat.com>
Cc: Andrew Morton <akpm@digeo.com>, Hugh Dickins <hugh@veritas.com>,
LW@KARO-electronics.de, linux-kernel@vger.kernel.org,
Jens Axboe <axboe@suse.de>
Subject: Re: [patch] cache flush bug in mm/filemap.c (all kernels >= 2.5.30(at least))
Date: Mon, 26 May 2003 09:55:51 +0100 [thread overview]
Message-ID: <20030526095551.C4417@flint.arm.linux.org.uk> (raw)
In-Reply-To: <1053919171.14018.2.camel@rth.ninka.net>; from davem@redhat.com on Sun, May 25, 2003 at 08:19:32PM -0700
On Sun, May 25, 2003 at 08:19:32PM -0700, David S. Miller wrote:
> Oh yes, this part is. If you don't ensure this, everything
> breaks.
>
> At the end of an I/O operation, say to a page cache page, that
> data ought to be visible equally to a userspace vs. a kernel
> space mapping to that page.
>
> For example, this is why we use language about "cpu visibility" in the
> DMA api documentation and not "kernel cpu visibility" :-) And because
> PIO transfers are basically pseudo-DMA they need to make the same exact
> guarentees.
>
> If you've been living in a world where you didn't think this is
> necessary, I certainly feel bad for you :-)
Ok, so the flush_dcache_page() interface looses this; the original
placement of the flush_page_to_ram() ensured that data written by
device drivers was visible to user space.
Maybe the BIO layer can handle this - the same problem exists when
(and if) BIO uses a bounce buffer, so it would have to be handled
there. Jens?
Lothar - can you confirm that your problem vanishes when you turn off
write allocation on the caches please? (cachepolicy=writeback)
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
next prev parent reply other threads:[~2003-05-26 8:42 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-22 12:34 [patch] cache flush bug in mm/filemap.c (all kernels >= 2.5.30(at least)) LW
2003-05-22 14:03 ` Russell King
2003-05-22 14:11 ` Russell King
2003-05-23 8:02 ` David S. Miller
2003-05-23 9:12 ` Andrew Morton
2003-05-23 9:49 ` David S. Miller
2003-05-23 10:04 ` Andrew Morton
2003-05-23 10:15 ` David S. Miller
2003-05-23 8:20 ` Lothar Wassmann
2003-05-23 9:24 ` Andrew Morton
2003-05-23 10:04 ` Lothar Wassmann
2003-05-23 10:45 ` Andrew Morton
2003-05-23 11:22 ` Paul Mackerras
2003-05-23 16:54 ` Russell King
2003-05-23 17:31 ` Hugh Dickins
2003-05-23 18:29 ` Andrew Morton
2003-05-23 18:34 ` Russell King
2003-05-26 3:19 ` David S. Miller
2003-05-26 5:07 ` Mika Penttilä
2003-05-26 5:08 ` David S. Miller
2003-05-26 5:36 ` Mika Penttilä
2003-05-26 5:36 ` David S. Miller
2003-05-26 13:18 ` Roman Zippel
2003-05-26 22:34 ` David S. Miller
2003-05-27 10:53 ` Roman Zippel
2003-05-27 21:22 ` David S. Miller
2003-05-28 16:35 ` Roman Zippel
2003-05-28 22:47 ` David S. Miller
2003-05-29 0:12 ` Roman Zippel
2003-05-29 1:37 ` David S. Miller
2003-05-29 7:13 ` Russell King
2003-05-29 7:15 ` David S. Miller
2003-05-29 17:49 ` Roman Zippel
2003-05-29 21:09 ` David S. Miller
2003-05-26 8:55 ` Russell King [this message]
2003-05-26 13:08 ` Lothar Wassmann
2003-05-26 22:19 ` Russell King
2003-05-26 13:25 ` Jens Axboe
2003-05-26 22:35 ` David S. Miller
2003-05-26 3:20 ` David S. Miller
2003-05-23 11:13 ` Russell King
2003-05-23 12:46 ` Lothar Wassmann
2003-05-23 15:42 ` Hugh Dickins
2003-05-25 17:10 ` David Woodhouse
2003-05-26 11:44 ` Lothar Wassmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030526095551.C4417@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=LW@KARO-electronics.de \
--cc=akpm@digeo.com \
--cc=axboe@suse.de \
--cc=davem@redhat.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).