From: Valdis.Kletnieks@vt.edu
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Linus Torvalds <torvalds@transmeta.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fixes trivial error in drivers/isdn/hardware/eicon/divamnt.c
Date: Tue, 27 May 2003 06:41:00 -0400 [thread overview]
Message-ID: <200305271041.h4RAf1J2007019@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Tue, 27 May 2003 20:21:02 +1000." <20030527102102.GA23378@gondor.apana.org.au>
[-- Attachment #1: Type: text/plain, Size: 329 bytes --]
On Tue, 27 May 2003 20:21:02 +1000, Herbert Xu said:
> This patch adds a pair of missing quotes.
> - devfs_mk_cdev(MKDEV(major, 0), S_IFCHR|S_IRUSR|S_IWUSR, DivasMAINT);
> + devfs_mk_cdev(MKDEV(major, 0), S_IFCHR|S_IRUSR|S_IWUSR, "DivasMAINT");
> return (1);
This smells like a missing #define DivasMAINT "Some Value Here"?
[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]
prev parent reply other threads:[~2003-05-27 11:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-27 10:21 [PATCH] Fixes trivial error in drivers/isdn/hardware/eicon/divamnt.c Herbert Xu
2003-05-27 10:41 ` Valdis.Kletnieks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200305271041.h4RAf1J2007019@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).