linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@digeo.com>
To: Roland McGrath <roland@redhat.com>
Cc: davidm@hpl.hp.com, torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: FIXMAP-related change to mm/memory.c
Date: Fri, 13 Jun 2003 00:15:17 -0700	[thread overview]
Message-ID: <20030613001517.5413e511.akpm@digeo.com> (raw)
In-Reply-To: <200306130656.h5D6uGc32359@magilla.sf.frob.com>

Roland McGrath <roland@redhat.com> wrote:
>
>  			static struct vm_area_struct fixmap_vma = {
>   				/* Catch users - if there are any valid
>   				   ones, we can make this be "&init_mm" or
>   				   something.  */
>   				.vm_mm = NULL,
>  -				.vm_start = FIXADDR_START,
>  -				.vm_end = FIXADDR_TOP,
>  +				.vm_start = FIXADDR_USER_START,
>  +				.vm_end = FIXADDR_USER_END,
>   				.vm_page_prot = PAGE_READONLY,
>   				.vm_flags = VM_READ | VM_EXEC,
>   			};

Note that the current version of this code does not compile for User Mode
Linux.  Its FIXADDR_TOP is not a constant.   It would be nice to fix that
this time around.

It appears that this patch will break x86_64, parisc and um.


  reply	other threads:[~2003-06-13  7:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-13  1:24 FIXMAP-related change to mm/memory.c David Mosberger
2003-06-13  2:07 ` Roland McGrath
2003-06-13  2:16   ` David Mosberger
2003-06-13  6:34     ` Roland McGrath
2003-06-13  6:37       ` David Mosberger
2003-06-13  6:56         ` Roland McGrath
2003-06-13  7:15           ` Andrew Morton [this message]
2003-06-15  6:51             ` Anton Blanchard
2003-06-13  7:17           ` David Mosberger
2003-06-13  5:24 ` Linus Torvalds
2003-06-13  7:28   ` [BUG] " Riley Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030613001517.5413e511.akpm@digeo.com \
    --to=akpm@digeo.com \
    --cc=davidm@hpl.hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roland@redhat.com \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).