linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Paul Mundt <lethal@linux-sh.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: SH Port - Makefile
Date: Sat, 14 Jun 2003 22:07:44 +0200	[thread overview]
Message-ID: <20030614200744.GA3921@mars.ravnborg.org> (raw)
In-Reply-To: <20030614194510.GD2216@linux-sh.org>

On Sat, Jun 14, 2003 at 02:45:12PM -0500, Paul Mundt wrote:
> Okay, the main reason why I needed to do this was so that a make clean
> would get the proper directory path. The problem was that machdir-y
> wasn't getting the board name correctly since at make clean time the
> CONFIG_SH_xxx names weren't being resolved.

The following should do the trick.
I also rearranged a few things.

Whith respect to removing the framepointer from CFLAGS.
There is already a CONFIG option for that CONFIG_FRAME_POINTER.
It would be much cleaner using that one in combination
with CONFIG_SH_KGDB

	Sam

===== arch/sh/Makefile 1.16 vs edited =====
--- 1.16/arch/sh/Makefile	Sat Jun 14 14:30:11 2003
+++ edited/arch/sh/Makefile	Sat Jun 14 22:03:10 2003
@@ -14,17 +14,6 @@
 # this architecture
 #
 
-#
-# We don't necessarily agree with the top-level Makefile with regards to what
-# does and does not qualify as a noconfig_targets rule. In this case, we're
-# still dependant on .config settings in order for core-y (machdir-y in
-# particular) to resolve the proper directory. So we just manually include it
-# if it hasn't been already..
-# 
-ifndef include_config
--include .config
-endif
-
 cpu-y				:= -mb
 cpu-$(CONFIG_CPU_LITTLE_ENDIAN)	:= -ml
 
@@ -66,24 +55,24 @@
 core-y				+= arch/sh/kernel/ arch/sh/mm/
 
 # Boards
-machdir-$(CONFIG_SH_SOLUTION_ENGINE)		:= se/770x
-machdir-$(CONFIG_SH_7751_SOLUTION_ENGINE)	:= se/7751
-machdir-$(CONFIG_SH_STB1_HARP)			:= harp
-machdir-$(CONFIG_SH_STB1_OVERDRIVE)		:= overdrive
-machdir-$(CONFIG_SH_HP620)			:= hp6xx/hp620
-machdir-$(CONFIG_SH_HP680)			:= hp6xx/hp680
-machdir-$(CONFIG_SH_HP690)			:= hp6xx/hp690
-machdir-$(CONFIG_SH_CQREEK)			:= cqreek
-machdir-$(CONFIG_SH_DMIDA)			:= dmida
-machdir-$(CONFIG_SH_EC3104)			:= ec3104
-machdir-$(CONFIG_SH_SATURN)			:= saturn
-machdir-$(CONFIG_SH_DREAMCAST)			:= dreamcast
-machdir-$(CONFIG_SH_CAT68701)			:= cat68701
-machdir-$(CONFIG_SH_BIGSUR)			:= bigsur
-machdir-$(CONFIG_SH_SH2000)			:= sh2000
-machdir-$(CONFIG_SH_ADX)			:= adx
-machdir-$(CONFIG_SH_MPC1211)			:= mpc1211
-machdir-$(CONFIG_SH_UNKNOWN)			:= unknown
+machdir-$(CONFIG_SH_SOLUTION_ENGINE)		:= se/770x/
+machdir-$(CONFIG_SH_7751_SOLUTION_ENGINE)	:= se/7751/
+machdir-$(CONFIG_SH_STB1_HARP)			:= harp/
+machdir-$(CONFIG_SH_STB1_OVERDRIVE)		:= overdrive/
+machdir-$(CONFIG_SH_HP620)			:= hp6xx/hp620/
+machdir-$(CONFIG_SH_HP680)			:= hp6xx/hp680/
+machdir-$(CONFIG_SH_HP690)			:= hp6xx/hp690/
+machdir-$(CONFIG_SH_CQREEK)			:= cqreek/
+machdir-$(CONFIG_SH_DMIDA)			:= dmida/
+machdir-$(CONFIG_SH_EC3104)			:= ec3104/
+machdir-$(CONFIG_SH_SATURN)			:= saturn/
+machdir-$(CONFIG_SH_DREAMCAST)			:= dreamcast/
+machdir-$(CONFIG_SH_CAT68701)			:= cat68701/
+machdir-$(CONFIG_SH_BIGSUR)			:= bigsur/
+machdir-$(CONFIG_SH_SH2000)			:= sh2000/
+machdir-$(CONFIG_SH_ADX)			:= adx/
+machdir-$(CONFIG_SH_MPC1211)			:= mpc1211/
+machdir-$(CONFIG_SH_UNKNOWN)			:= unknown/
 
 incdir-y			:= $(machdir-y)
 
@@ -91,7 +80,7 @@
 incdir-$(CONFIG_SH_7751_SOLUTION_ENGINE)	:= se7751
 incdir-$(CONFIG_SH_HP600)			:= hp6xx
 
-core-y				+= arch/sh/boards/$(machdir-y)/
+core-y				+= arch/sh/boards/$(machdir-y)
 
 # Companion chips
 core-$(CONFIG_HD64461)	+= arch/sh/cchips/hd6446x/hd64461/
@@ -103,7 +92,6 @@
 
 libs-y				+= arch/sh/lib/	$(LIBGCC)
 
-boot := arch/sh/boot
 
 AFLAGS_vmlinux.lds.o := -traditional
 
@@ -119,11 +107,10 @@
 
 	$(Q)$(MAKE) $(build)=arch/sh/tools include/asm-sh/machtypes.h
 
-BOOTIMAGE=arch/sh/boot/zImage
-zImage: vmlinux
-	$(Q)$(MAKE) $(build)=$(boot) $(BOOTIMAGE)
+boot := arch/sh/boot
 
-compressed: zImage
+zImage: vmlinux
+	$(Q)$(MAKE) $(build)=$(boot) arch/sh/boot/zImage
 
 archclean:
 	$(Q)$(MAKE) $(clean)=$(boot)


  reply	other threads:[~2003-06-14 19:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-14 19:30 SH Port - Makefile Sam Ravnborg
2003-06-14 19:45 ` Paul Mundt
2003-06-14 20:07   ` Sam Ravnborg [this message]
2003-06-15  4:50     ` Paul Mundt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030614200744.GA3921@mars.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).