From: Pavel Machek <pavel@suse.cz>
To: CaT <cat@zip.com.au>
Cc: Pavel Machek <pavel@suse.cz>,
swsusp@lister.fornax.hu, linux-kernel@vger.kernel.org
Subject: Re: can't get linux to perform a bios suspend (was: Re: [FIX, please test] Re: 2.5.70-bk16 - nfs interferes with s4bios suspend)
Date: Sun, 22 Jun 2003 17:15:49 +0200 [thread overview]
Message-ID: <20030622151549.GD199@elf.ucw.cz> (raw)
In-Reply-To: <20030621142400.GB5388@zip.com.au>
Hi!
> > > Ponderance: Why did it do a full s/w suspend when I asked for the bios
> > > to handle it? I have s4bios showing up in /proc/acpi/sleep and the bios
> > > is set to suspend to disk. I've even got an a0 partition fully formatted
> > > and it still ignored it all.
> >
> > I don't know, try looking at drivers/acpi/sleep/main.c, and if
> > neccessary insert some printk()s to see what's going on.
>
> I've had a wee look into it and if I remove software suspend from the
> compile, I get no sleep states at all. period. /proc/acpi/sleep does
> not exist and nothing is reported in dmesg.
>
> Now I had a look in drivers/acpi/sleep and in the proc.c file I found
> this bit of code:
>
> ...
> state = simple_strtoul(state_string, NULL, 0);
>
> if (state < 1 || state > 4)
> goto Done;
>
> if (!sleep_states[state])
> goto Done;
>
> #ifdef CONFIG_SOFTWARE_SUSPEND
> if (state == 4) {
> software_suspend();
> goto Done;
> }
> #endif
> status = acpi_suspend(state);
> ...
>
> To me this appears to indicate that it's treating a request for a
> sleep state of 4 (s/w suspend) and 4b (bios suspend) as the same thing
> as simple_strtoul will stop at the b and return 4 and there are no
> further checks being done. In a small experiment I added a test of
> state_string[1] == 'b', recompiled and tried it again. It did not go
> into s/w suspend as expected but it failed to do a suspend alltogether.
>
> At this point I'm slightly lost. To me it's obvious that there's
> something whacky with acpi_suspend() or something it calls but I'm
> not sure what. :/
If you have 2.4.X, get 2.5.72. That should have
do_suspend_lowlevel_s4bios in wakeup.S. Look around and fix it so that
it is called when user does echo 4b. It may well be broken.
Pavel
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
next prev parent reply other threads:[~2003-06-22 15:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-13 3:37 2.5.70-bk16 - nfs interferes with s4bios suspend CaT
2003-06-13 6:30 ` Pavel Machek
2003-06-15 18:06 ` Pavel Machek
2003-06-15 23:00 ` CaT
2003-06-15 23:16 ` Pavel Machek
2003-06-15 18:31 ` [FIX, please test] " Pavel Machek
2003-06-16 0:11 ` CaT
2003-06-16 1:41 ` [Swsusp] " Michael Frank
2003-06-16 10:47 ` Pavel Machek
2003-06-18 8:16 ` CaT
2003-06-18 10:17 ` Pavel Machek
2003-06-18 10:26 ` CaT
2003-06-18 10:35 ` Pavel Machek
2003-06-21 14:24 ` can't get linux to perform a bios suspend (was: Re: [FIX, please test] Re: 2.5.70-bk16 - nfs interferes with s4bios suspend) CaT
2003-06-22 15:15 ` Pavel Machek [this message]
2003-06-23 0:58 ` CaT
2003-06-23 9:50 ` Pavel Machek
2003-06-23 9:58 ` CaT
2003-07-01 8:03 ` CaT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030622151549.GD199@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=cat@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=swsusp@lister.fornax.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).