From: Daniel Phillips <phillips@arcor.de>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linus Torvalds <torvalds@transmeta.com>,
perex@suse.cz,
Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Isapnp warning
Date: Sun, 22 Jun 2003 16:07:14 +0200 [thread overview]
Message-ID: <200306221607.15232.phillips@arcor.de> (raw)
In-Reply-To: <1056198688.25975.25.camel@dhcp22.swansea.linux.org.uk>
Hi Alan,
On Saturday 21 June 2003 14:31, Alan Cox wrote:
> On Sul, 2003-06-15 at 19:36, Geert Uytterhoeven wrote:
> > Isapnp: Kill warning if CONFIG_PCI is not set
> >
> > --- linux-2.5.x/drivers/pnp/resource.c Tue May 27 19:03:04 2003
> > +++ linux-m68k-2.5.x/drivers/pnp/resource.c Sun Jun 8 13:31:20 2003
> > @@ -97,7 +97,9 @@
> >
> > int pnp_add_irq_resource(struct pnp_dev *dev, int depnum, struct pnp_irq *data)
> > {
> > +#ifdef CONFIG_PCI
> > int i;
> > +#endif
>
> This is far uglier than te warning
How about:
#define if_pci(tokens...) tokens
int pnp_add_irq_resource(struct pnp_dev *dev, int depnum, struct pnp_irq *data)
{
if_pci(int i);
...
}
Admittedly uglier than just having the warning disabled by default.
Regards,
Daniel
next prev parent reply other threads:[~2003-06-22 13:52 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-15 18:36 [PATCH] Isapnp warning Geert Uytterhoeven
2003-06-21 12:31 ` Alan Cox
2003-06-21 14:59 ` Geert Uytterhoeven
2003-06-21 15:04 ` Sean Neakums
2003-06-21 19:51 ` Andrew Morton
2003-06-21 23:53 ` Linus Torvalds
2003-06-22 0:11 ` Arnaldo Carvalho de Melo
2003-06-22 1:41 ` Chris Wedgwood
2003-06-22 1:43 ` Arnaldo Carvalho de Melo
2003-06-22 2:17 ` Andrew Morton
2003-06-22 2:27 ` Chris Wedgwood
2003-06-22 2:59 ` Andrew Morton
2003-06-22 5:50 ` Herbert Xu
2003-06-22 3:43 ` Martin J. Bligh
2003-06-22 4:24 ` Paul Mackerras
2003-06-22 8:32 ` Geert Uytterhoeven
2003-06-22 13:34 ` Daniel Phillips
2003-06-22 5:39 ` gcc 3.3: largest *and* smallest kernels (was Re: [PATCH] Isapnp warning) Barry K. Nathan
2003-06-22 11:31 ` Alan Cox
2003-06-22 13:22 ` GCC speed (was " Daniel Phillips
2003-06-22 17:32 ` Andrew Morton
2003-06-22 17:56 ` Linus Torvalds
2003-06-22 18:58 ` Henning P. Schmiedehausen
2003-06-22 19:12 ` Sam Ravnborg
2003-06-22 19:13 ` Andrew Morton
2003-06-22 19:32 ` Henning Schmiedehausen
2003-06-22 19:51 ` Adrian Bunk
2003-06-22 19:12 ` Daniel Phillips
2003-06-23 1:05 ` Larry McVoy
2002-01-04 11:32 ` Pavel Machek
2003-07-17 10:18 ` Christoph Hellwig
2003-07-17 10:23 ` Jakub Jelinek
2003-07-17 10:27 ` Christoph Hellwig
2003-06-22 8:49 ` [PATCH] Isapnp warning Russell King
2003-06-22 8:39 ` Jörn Engel
2003-06-22 14:07 ` Daniel Phillips [this message]
2003-06-22 15:00 ` Jan-Benedict Glaw
-- strict thread matches above, loose matches on Subject: below --
2003-08-29 14:49 Geert Uytterhoeven
2003-06-15 19:10 Geert Uytterhoeven
2003-06-09 10:37 Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200306221607.15232.phillips@arcor.de \
--to=phillips@arcor.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@suse.cz \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).