From: Rusty Russell <rusty@rustcorp.com.au>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: support@moxa.com.tw, linux-kernel@vger.kernel.org
Subject: Re: [2.5 patch] remove two unused variables from mxser.c
Date: Mon, 30 Jun 2003 12:01:58 +1000 [thread overview]
Message-ID: <20030630025802.E85162C220@lists.samba.org> (raw)
In-Reply-To: Your message of "Sat, 28 Jun 2003 04:39:36 +0200." <20030628023935.GQ24661@fs.tum.de>
In message <20030628023935.GQ24661@fs.tum.de> you write:
> On Fri, Jun 20, 2003 at 02:31:06PM +1000, Rusty Russell wrote:
> > In message <20030619231222.GF29247@fs.tum.de> you write:
> > > The patch below removes two unused variables from drivers/char/mxser.c .
> >
> > While you're there, would you fix the init returning "-1" for no good
> > reason at the bottom, too? (I don't think they really meant EPERM).
>
> There is at least one other driver under drivers/char/ doing the
> same...
>
> Which return code do you suggest?
Looking at the code, there are other problems.
The last thing to fail (which triggers this -1 return) is
tty_register_driver(mxvar_sdriver): so keep that return code and use
it.
But they do put_tty_driver(mxvar_sdriver) in the failure path, which
seems wrong, too...
Good luck!
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
prev parent reply other threads:[~2003-06-30 2:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-19 23:12 [2.5 patch] remove two unused variables from mxser.c Adrian Bunk
2003-06-20 4:31 ` Rusty Russell
2003-06-28 2:39 ` Adrian Bunk
2003-06-30 2:01 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030630025802.E85162C220@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=bunk@fs.tum.de \
--cc=linux-kernel@vger.kernel.org \
--cc=support@moxa.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).