From: Oleg Drokin <green@namesys.com>
To: steven.newbury1@ntlworld.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] BadRAM for 2.5.73-mm2
Date: Wed, 2 Jul 2003 10:23:24 +0400 [thread overview]
Message-ID: <20030702062324.GA1561@namesys.com> (raw)
In-Reply-To: <20030702033326.HNID28183.mta05-svc.ntlworld.com@[10.137.100.64]>
Hello!
On Wed, Jul 02, 2003 at 03:33:26AM +0000, steven.newbury1@ntlworld.com wrote:
> It will probably apply cleanly to 2.5.73 as well but I haven't checked it
> yet...
This
> It is based it on
> http://rick.vanrein.org/linux/badram/software/BadRAM-2.4.20.1.patch
and this patches both have a bug that effectively disables all highmem (if present)
when badram patch is activated. I contacted Rick, but never got any answer back.
(in fact I got an auto reply from some Debian bugtracking system, but that's about it).
Corrected 2.4.21 version of the patch is available at
http://linuxhacker.ru/patches/2.4.21-badram.diff
The arch/i386/mm/init.c part:
> +void __init one_highpage_init(struct page *page, int pfn, int bad_ppro,
> + _Bool *bad)
> {
> + *bad = 0;
> if (page_is_ram(pfn) && !(bad_ppro && page_kills_ppro(pfn))) {
> ClearPageReserved(page);
> set_bit(PG_highmem, &page->flags);
> set_page_count(page, 1);
> - __free_page(page);
> +#ifdef CONFIG_BADRAM
> + if (PageBad(page))
> + *bad = 1;
> + else
> +#else
> + __free_page(page);
> +#endif
> totalhigh_pages++;
should obviously get "#else" replaced with "#endif" and original "#endif" should be removed
because otherwise all of the highmem pages are either bad or used right from the initialisation.
(Yes, I have highmem (2G RAM) system with 2 bits bad and I am too lazy to to go to the store to
replace the RAM modules, so I given a patch a try and discovered this problem (which is there
for a long time it seems). I suspect that I am the only one who runs this patch on highmem system,
though ;) )
Bye,
Oleg
next prev parent reply other threads:[~2003-07-02 6:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-02 3:33 [PATCH] BadRAM for 2.5.73-mm2 steven.newbury1
2003-07-02 6:23 ` Oleg Drokin [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-07-02 8:56 Etienne Lorrain
2003-07-02 3:18 Steven Newbury
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030702062324.GA1561@namesys.com \
--to=green@namesys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=steven.newbury1@ntlworld.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).