From: viro@parcelfarce.linux.theplanet.co.uk
To: Jan Kratochvil
<rcpt-linux-fsdevel.AT.vger.kernel.org@jankratochvil.net>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
chaffee@cs.berkeley.edu, zippel@linux-m68k.org
Subject: Re: [PATCH] vfat+affs case preservation
Date: Wed, 2 Jul 2003 11:34:57 +0100 [thread overview]
Message-ID: <20030702103457.GS27348@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20030702102538.GA16711@exuhome.dyn.jankratochvil.net>
On Wed, Jul 02, 2003 at 12:25:38PM +0200, Jan Kratochvil wrote:
> +/* We have to always do the revalidate as after unlink (etc.) there still may
> + * exist other case-different dentries for the same inode. It would be also
> + * possible to discard such aliases by going through d_alias links during the
> + * unlink. "strictcase" does not have case-different dentries but "longna~1"
> + * style aliases still exist there.
> + */
> - alias = d_find_alias(inode);
> - if (alias) {
> - if (d_invalidate(alias)==0)
> - dput(alias);
> - else {
> - iput(inode);
> - unlock_kernel();
> - return alias;
> - }
> -
> - }
Broken. With that we can get two active dentries for the same directory.
There goes any cache coherency, with all usual results.
next prev parent reply other threads:[~2003-07-02 10:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-02 10:25 [PATCH] vfat+affs case preservation Jan Kratochvil
2003-07-02 10:34 ` viro [this message]
2003-07-02 10:53 ` Jan Kratochvil
2003-07-02 12:04 ` viro
2003-07-02 18:28 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030702103457.GS27348@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=chaffee@cs.berkeley.edu \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rcpt-linux-fsdevel.AT.vger.kernel.org@jankratochvil.net \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).