linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anton Blanchard <anton@samba.org>
To: rwhron@earthlink.net
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix return of compat_sys_sched_getaffinity
Date: Mon, 7 Jul 2003 02:31:37 +1000	[thread overview]
Message-ID: <20030706163137.GK13308@krispykreme> (raw)
In-Reply-To: <20030706162400.GA15526@rushmore>


> -EFAULT return got buggered when compat_sys_sched_getaffinity
> was added in 2.5.68.

but getaffinity returns sizeof(compat_ulong_t) on success...

Anton

> --- linux-2.5.74/kernel/compat.c.orig	2003-06-22 15:54:17.000000000 -0400
> +++ linux-2.5.74/kernel/compat.c	2003-07-06 11:29:33.000000000 -0400
> @@ -425,11 +425,9 @@
>  				    &kernel_mask);
>  	set_fs(old_fs);
>  
> -	if (ret > 0) {
> +	if (ret > 0)
>  		if (put_user(kernel_mask, user_mask_ptr))
> -			ret = -EFAULT;
> -		ret = sizeof(compat_ulong_t);
> -	}
> +			return -EFAULT;
>  
>  	return ret;
>  }

      reply	other threads:[~2003-07-06 16:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-06 16:24 rwhron
2003-07-06 16:31 ` Anton Blanchard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030706163137.GK13308@krispykreme \
    --to=anton@samba.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rwhron@earthlink.net \
    --subject='Re: [PATCH] fix return of compat_sys_sched_getaffinity' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).