pppoe, fix old protocol handler

pppoe, fix old protocol handler

[Jan Dittmer]

Hi,

I'm using 2.5(.73-mm3, but this also applies to earlier versions) and 
I'm getting tons (~6000/min) of "fix old protocol handler <pppoed>!" in 
my syslog on a quite loaded adsl line. For the time being I just 
commented out the annoying code fragment  and I didn't find any 
regressions yet (uptime ~20days).
So what's the correct way of getting rid of this message? I tried 
recompiling pppd and pppoe, but that doesn't solve it. Is there a 
patched version somewhere.

Thanks,

Jan

pppd version 2.4.2b3
Roaring Penguin PPPoE Version 3.5

--- a/net/core/dev.c    Sun Jun 15 19:11:37 2003
+++ b/net/core/dev.c    Sun Jun 15 19:11:53 2003
@@ -1370,8 +1370,8 @@
  #ifdef CONFIG_SMP
         /* Old protocols did not depened on BHs different of NET_BH and
            TIMER_BH - they need to be fixed for the new assumptions.
-        */
         print_symbol("fix old protocol handler %s!\n", (unsigned 
long)pt->func);
+        */
  #endif
         ret = pt->func(skb, skb->dev, pt);
  out:

Re: pppoe, fix old protocol handler

[David S. Miller]

Current 2.5.x should not print those messages anymore,
pppoe has been converted over to not be an "old protocol"
any more.