From: Thomas Schlichter <schlicht@uni-mannheim.de>
To: smiler@lanil.mine.nu, linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org
Subject: Re: 2.5.74-mm2 + nvidia (and others)
Date: Mon, 7 Jul 2003 17:33:53 +0200 [thread overview]
Message-ID: <200307071734.01575.schlicht@uni-mannheim.de> (raw)
In-Reply-To: <1057590519.12447.6.camel@sm-wks1.lan.irkk.nu>
[-- Attachment #1: Type: text/plain, Size: 590 bytes --]
Am Monday 07 July 2003 17:08 schrieb Christian Axelsson:
> Ok, running fine with 2.5.74-mm2 but when I try to insert the nvidia
> module (with patches from www.minion.de applied) it gives
>
> nvidia: Unknown symbol pmd_offset
>
> in dmesg. The vmware vmmon module gives the same error (the others wont
> compile but thats a different story).
>
> The nvidia module works fine under plain 2.5.74.
The problem is the highpmd patch in -mm2. There are two options:
1. Revert the highpmd patch.
2. Apply the attached patch to the NVIDIA kernel module sources.
Best regards
Thomas Schlichter
[-- Attachment #2: NVIDIA_kernel-1.0-4363-highpmd.diff --]
[-- Type: text/x-diff, Size: 1384 bytes --]
--- NVIDIA_kernel-1.0-4363/nv-linux.h.orig Sun Jul 6 14:42:34 2003
+++ NVIDIA_kernel-1.0-4363/nv-linux.h Mon Jul 7 14:57:02 2003
@@ -225,6 +225,18 @@
}
#endif
+#if defined(pmd_offset_map)
+#define NV_PMD_OFFSET(address, pg_dir, pg_mid_dir) \
+ { \
+ pmd_t *pg_mid_dir__ = pmd_offset_map(pg_dir, address); \
+ pg_mid_dir = *pg_mid_dir__; \
+ pmd_unmap(pg_mid_dir__); \
+ }
+#else
+#define NV_PMD_OFFSET(address, pg_dir, pg_mid_dir) \
+ pg_mid_dir = *pmd_offset(pg_dir, address)
+#endif
+
#define NV_PAGE_ALIGN(addr) ( ((addr) + PAGE_SIZE - 1) / PAGE_SIZE)
#define NV_MASK_OFFSET(addr) ( (addr) & (PAGE_SIZE - 1) )
--- NVIDIA_kernel-1.0-4363/nv.c.orig Sun Jul 6 14:45:36 2003
+++ NVIDIA_kernel-1.0-4363/nv.c Sun Jul 6 14:58:55 2003
@@ -2084,7 +2084,7 @@
nv_get_phys_address(unsigned long address)
{
pgd_t *pg_dir;
- pmd_t *pg_mid_dir;
+ pmd_t pg_mid_dir;
pte_t pte;
#if defined(NVCPU_IA64)
@@ -2105,11 +2105,12 @@
if (pgd_none(*pg_dir))
goto failed;
- pg_mid_dir = pmd_offset(pg_dir, address);
- if (pmd_none(*pg_mid_dir))
+ NV_PMD_OFFSET(address, pg_dir, pg_mid_dir);
+
+ if (pmd_none(pg_mid_dir))
goto failed;
- NV_PTE_OFFSET(address, pg_mid_dir, pte);
+ NV_PTE_OFFSET(address, &pg_mid_dir, pte);
if (!pte_present(pte))
goto failed;
next prev parent reply other threads:[~2003-07-07 15:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-07 15:08 2.5.74-mm2 + nvidia (and others) Christian Axelsson
2003-07-07 15:33 ` Thomas Schlichter [this message]
2003-07-07 17:09 ` Christian Axelsson
2003-07-07 19:30 ` Andrew Morton
2003-07-08 7:03 ` Martin Schlemmer
2003-07-08 7:26 ` William Lee Irwin III
2003-07-08 8:51 ` Thomas Schlichter
2003-07-08 8:55 ` William Lee Irwin III
2003-07-08 9:37 ` Peter C. Ndikuwera
2003-07-08 11:01 ` Petr Vandrovec
2003-07-08 11:23 ` Flameeyes
2003-07-08 11:26 ` William Lee Irwin III
2003-07-08 11:35 ` Christian Axelsson
2003-07-08 11:40 ` Christian Axelsson
2003-07-12 1:21 ` William Lee Irwin III
2003-07-14 12:09 ` Martin Schlemmer
2003-07-14 16:51 ` Thomas Schlichter
2003-07-07 23:08 ` William Lee Irwin III
2003-07-08 12:37 Petr Vandrovec
2003-07-08 12:57 ` Flameeyes
2003-07-08 13:02 ` Christian Axelsson
2003-07-08 13:07 ` Petr Vandrovec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200307071734.01575.schlicht@uni-mannheim.de \
--to=schlicht@uni-mannheim.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=smiler@lanil.mine.nu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).