From: Christoph Hellwig <hch@infradead.org>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] AES for CryptoAPI - i586-optimized
Date: Tue, 8 Jul 2003 17:49:07 +0100 [thread overview]
Message-ID: <20030708174907.A18997@infradead.org> (raw)
In-Reply-To: <20030708152755.GA24331@ghanima.endorphin.org>; from clemens@endorphin.org on Tue, Jul 08, 2003 at 05:27:55PM +0200
On Tue, Jul 08, 2003 at 05:27:55PM +0200, Fruhwirth Clemens wrote:
>
> Due to the recent discussion about the asm-optimized version of AES which is
> included in loop-AES, I'd like to point out that I've ported this
> implementation - Dr. Brian Gladman's btw. - to CryptoAPI a long time ago.
Cool, that means we just need to hash out the framework for optimized
implementations now..
A few more comments:
> diff -r --new-file -u crypto/Kconfig ../linux-2.5.58/crypto/Kconfig
> --- crypto/Kconfig Thu Feb 6 13:53:47 2003
> +++ ../linux-2.5.58/crypto/Kconfig Tue Feb 4 00:54:18 2003
> @@ -119,6 +119,26 @@
>
> See http://csrc.nist.gov/encryption/aes/ for more information.
>
> +config CRYPTO_AES_586
> + tristate "AES cipher algorithms (586)"
> + depends on CRYPTO
Should also depend on CONFIG_X86 && !CONFIG_X86_64
> +$(obj)/aes-i586.o: $(obj)/aes-i586-asm.o crypto/aes-i586-glue.o
> + $(LD) -r $(obj)/aes-i586-asm.o $(obj)/aes-i586-glue.o -o $(obj)/aes-i586.o
That's not how kernel makesfile work. It should be something like
aes-i586-y := aes-i586-asm.o aes-i586-glue.o
> +// THE CIPHER INTERFACE
Please use C-style comments.
> + if(key_length != 16 && key_length != 24 && key_length != 32)
> + {
Should be
if (key_length != 16 && key_length != 24 && key_length != 32) {
> +MODULE_DESCRIPTION("Rijndael (AES) Cipher Algorithm");
> +MODULE_LICENSE("Dual BSD/GPL");
MODULE_AUTHOR is missing. Also the description should mention that
this is an optimized assembly version.
next prev parent reply other threads:[~2003-07-08 16:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-08 15:27 [PATCH] AES for CryptoAPI - i586-optimized Fruhwirth Clemens
2003-07-08 16:49 ` Christoph Hellwig [this message]
[not found] <20030708152755.GA24331@ghanima.endorphin.org.suse.lists.linux.kernel>
[not found] ` <20030708174907.A18997@infradead.org.suse.lists.linux.kernel>
2003-07-08 17:12 ` Andi Kleen
2003-07-08 17:28 ` Jeff Garzik
2003-07-08 19:16 ` Andi Kleen
2003-07-22 1:17 Jason Papadopoulos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030708174907.A18997@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).