linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Nikita Danilov <Nikita@Namesys.COM>
Cc: Linux-Kernel@vger.kernel.org
Subject: Re: [PATCH] 1/5 VM changes: zone-pressure.patch
Date: Wed, 9 Jul 2003 03:12:03 -0700	[thread overview]
Message-ID: <20030709031203.3971d9b4.akpm@osdl.org> (raw)
In-Reply-To: <16139.54887.932511.717315@laputa.namesys.com>

Nikita Danilov <Nikita@Namesys.COM> wrote:
>
> Add zone->pressure field. It estimates scanning intensity for this zone and
>  is calculated as exponentially decaying average of the scanning priority
>  required to free enough pages in this zone (mm/vmscan.c:zone_adj_pressure()).
> 
>  zone->pressure is supposed to be used in stead of scanning priority by
>  vmscan.c. This is used by later patches in a series.
> 

OK, fixes a bug.

> 
>  diff -puN include/linux/mmzone.h~zone-pressure include/linux/mmzone.h
>  --- i386/include/linux/mmzone.h~zone-pressure	Wed Jul  9 12:24:50 2003
>  +++ i386-god/include/linux/mmzone.h	Wed Jul  9 12:24:50 2003
>  @@ -84,11 +84,23 @@ struct zone {
>   	atomic_t		refill_counter;
>   	unsigned long		nr_active;
>   	unsigned long		nr_inactive;
>  -	int			all_unreclaimable; /* All pages pinned */
>  +	int			all_unreclaimable:1; /* All pages pinned */

I'll revert this change.  Once we start adding bitfields in there they all
need common locking and it gets messy.  integers are simpler.


  reply	other threads:[~2003-07-09  9:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-09  8:46 Nikita Danilov
2003-07-09 10:12 ` Andrew Morton [this message]
2003-07-09 10:20   ` Nikita Danilov
2003-07-09 10:42     ` Andrew Morton
2003-07-09 11:19       ` Nikita Danilov
2003-07-10 14:40       ` Martin Schlemmer
2003-07-17 13:50       ` Nikita Danilov
2003-07-09 10:22 ` Andrew Morton
2003-07-09 10:30   ` Nikita Danilov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030709031203.3971d9b4.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=Linux-Kernel@vger.kernel.org \
    --cc=Nikita@Namesys.COM \
    --subject='Re: [PATCH] 1/5 VM changes: zone-pressure.patch' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).