From: Werner Almesberger <wa@almesberger.net>
To: "David S. Miller" <davem@redhat.com>
Cc: hch@infradead.org, jmorris@intercode.com.au, TSPAT@de.ibm.com,
linux-kernel@vger.kernel.org
Subject: Re: crypto API and IBM z990 hardware support
Date: Wed, 9 Jul 2003 23:06:37 -0300 [thread overview]
Message-ID: <20030709230637.A6409@almesberger.net> (raw)
In-Reply-To: <20030709.180830.39180836.davem@redhat.com>; from davem@redhat.com on Wed, Jul 09, 2003 at 06:08:30PM -0700
David S. Miller wrote:
> Bad example, I'd say that %65 of that file is used in net/ipv6/*.c
> files too.
Considering only inline functions, 64 of the 89 functions my script
below finds in my 2.5.72 tree are only used in net/ipv4 (or tcp.h
itself). That's almost 72%. Only 22 of the functions (25%) are used
in net/ipv6.
A lot of the code there is basically an extension of net/ipv4/tcp*.c,
so it seems odd to put it at a completely different location, only
because it happens to be inlined.
#!/bin/sh
SRC=include/net/tcp.h
for n in `sed '/^.*inline.* \([a-zA-Z_0-9]*\)([^;]*$/s//\1/p;d' <$SRC`; do
echo -n "$n: "
echo `find . -name '*.[ch]' | fgrep -vx ./$SRC | xargs grep -lrw $n`
done
File is "out":
wc -l out
89 out
sed 's|\./net/ipv4/[^/]*\>||g' <out | fgrep -v . | wc -l
64
sed 's|\./net/ipv4/[^/]*\>||g' <out | grep -c net/ipv6
22
- Werner
--
_________________________________________________________________________
/ Werner Almesberger, Buenos Aires, Argentina wa@almesberger.net /
/_http://www.almesberger.net/____________________________________________/
next prev parent reply other threads:[~2003-07-10 1:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-02 7:07 crypto API and IBM z990 hardware support Thomas Spatzier
2003-07-02 9:35 ` James Morris
2003-07-07 7:09 ` Christoph Hellwig
2003-07-08 2:53 ` David S. Miller
2003-07-08 3:37 ` Roland Dreier
2003-07-08 3:35 ` David S. Miller
2003-07-10 1:08 ` Werner Almesberger
2003-07-10 1:08 ` David S. Miller
2003-07-10 2:06 ` Werner Almesberger [this message]
2003-07-10 2:06 ` David S. Miller
2003-07-10 2:37 ` Werner Almesberger
2003-07-11 0:02 ` David S. Miller
[not found] ` <mailman.1057799700.15422.linux-kernel2news@redhat.com>
2003-07-10 5:55 ` Pete Zaitcev
2003-07-02 12:35 Thomas Spatzier
2003-07-02 16:57 ` James Morris
2003-07-07 7:11 ` Christoph Hellwig
2003-07-07 10:27 ` James Morris
2003-07-02 20:23 Ulrich Weigand
[not found] <4P45.5YN.11@gated-at.bofh.it>
[not found] ` <4T81.24d.41@gated-at.bofh.it>
2003-07-02 22:06 ` Arnd Bergmann
2003-07-06 14:08 ` James Morris
2003-07-06 17:46 ` Arnd Bergmann
2003-07-07 7:14 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030709230637.A6409@almesberger.net \
--to=wa@almesberger.net \
--cc=TSPAT@de.ibm.com \
--cc=davem@redhat.com \
--cc=hch@infradead.org \
--cc=jmorris@intercode.com.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).