From: Christoph Hellwig <hch@infradead.org>
To: Anders Gustafsson <andersg@0x63.nu>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] add xbox subarchitecture
Date: Thu, 10 Jul 2003 19:09:18 +0100 [thread overview]
Message-ID: <20030710190918.A12653@infradead.org> (raw)
In-Reply-To: <20030710172802.GB27744@h55p111.delphi.afb.lu.se>; from andersg@0x63.nu on Thu, Jul 10, 2003 at 07:28:02PM +0200
> targets := vmlinux vmlinux.bin vmlinux.bin.gz head.o misc.o piggy.o
> +ifeq ($(CONFIG_X86_XBOX),y)
> +#XXX Compiling with optimization makes 1.1-xboxen
> +# crash while decompressing the kernel
> +CFLAGS_misc.o := -O0
> +endif
I don't think this should go in until it's clear that it's not a gcc
problem.
> + if (mach_pci_is_blacklisted(bus,PCI_SLOT(devfn),PCI_FUNC(devfn)))
there's a few space missing..
> +#ifndef __ASM_MACH_PCI_BLACKLIST_H
> +#define __ASM_MACH_PCI_BLACKLIST_H
> +
> +#define mach_pci_is_blacklisted(bus,dev,fn) ( (bus>1) || (bus&&(dev||fn)) || ((bus==0 && dev==0) && ((fn==1)||(fn==2))) )
#define mach_pci_is_blacklisted(bus, dev, fn) \
((bus > 1) || (bus && (dev || fn)) || \
((!bus && !dev) && ((fn == 1) || (fn == 2))))
or even better an inline function
next prev parent reply other threads:[~2003-07-10 17:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-10 17:28 [PATCH] add xbox subarchitecture Anders Gustafsson
2003-07-10 18:09 ` Christoph Hellwig [this message]
2003-07-11 8:29 ` Anders Gustafsson
2003-07-11 8:45 ` Christoph Hellwig
2003-07-11 9:03 ` Anders Gustafsson
2003-07-10 19:37 Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030710190918.A12653@infradead.org \
--to=hch@infradead.org \
--cc=andersg@0x63.nu \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).