linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Francois Romieu <romieu@fr.zoreil.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: [PATCH] Re: PATCH: Merge AD1889 driver from 2.4
Date: Sat, 12 Jul 2003 00:45:01 +0200	[thread overview]
Message-ID: <20030712004501.B25528@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <200307111821.h6BILFpr017428@hraefn.swansea.linux.org.uk>; from alan@lxorguk.ukuu.org.uk on Fri, Jul 11, 2003 at 07:21:15PM +0100

The following patch may help:

- include/linux/wrapper.h doesn't exist in 2.5.75 and none of it's content
  is used by the driver;
- s/MINOR/minor/;
- KConfig/Makefile update.


 sound/oss/Kconfig  |    7 +++++++
 sound/oss/Makefile |    1 +
 sound/oss/ad1889.c |    6 +++---
 3 files changed, 11 insertions(+), 3 deletions(-)

diff -puN sound/oss/ad1889.c~ahum-merge-ad1889 sound/oss/ad1889.c
--- linux-2.5.75-20030711_0808/sound/oss/ad1889.c~ahum-merge-ad1889	Sat Jul 12 00:40:26 2003
+++ linux-2.5.75-20030711_0808-fr/sound/oss/ad1889.c	Sat Jul 12 00:40:26 2003
@@ -37,7 +37,7 @@
 #include <linux/soundcard.h>
 #include <linux/ac97_codec.h>
 #include <linux/sound.h>
-#include <linux/wrapper.h>
+#include <linux/interrupt.h>
 
 #include <asm/delay.h>
 #include <asm/io.h>
@@ -749,7 +749,7 @@ static int ad1889_ioctl(struct inode *in
 static int ad1889_open(struct inode *inode, struct file *file)
 {
 	/* check minor; only support /dev/dsp atm */
-	if (MINOR(inode->i_rdev) != 3)
+	if (minor(inode->i_rdev) != 3)
 		return -ENXIO;
 	
 	file->private_data = ad1889_dev;
@@ -782,7 +782,7 @@ static struct file_operations ad1889_fop
 /************************* /dev/mixer interfaces ************************ */
 static int ad1889_mixer_open(struct inode *inode, struct file *file)
 {
-	if (ad1889_dev->ac97_codec->dev_mixer != MINOR(inode->i_rdev))
+	if (ad1889_dev->ac97_codec->dev_mixer != minor(inode->i_rdev))
 		return -ENODEV;
 
 	file->private_data = ad1889_dev->ac97_codec;
diff -puN sound/oss/Kconfig~ahum-merge-ad1889 sound/oss/Kconfig
--- linux-2.5.75-20030711_0808/sound/oss/Kconfig~ahum-merge-ad1889	Sat Jul 12 00:40:26 2003
+++ linux-2.5.75-20030711_0808-fr/sound/oss/Kconfig	Sat Jul 12 00:40:26 2003
@@ -598,6 +598,13 @@ config SOUND_AD1816
 	  If you compile the driver into the kernel, you have to add
 	  "ad1816=<io>,<irq>,<dma>,<dma2>" to the kernel command line.
 
+config SOUND_AD1889
+	tristate "AD1889 based cards (AD1819 codec) (EXPERIMENTAL)"
+	depends on EXPERIMENTAL && SOUND_OSS
+	help
+	  Say M here if you have a sound card based on the Analog Devices
+	  AD1889 chip.
+
 config SOUND_SGALAXY
 	tristate "Aztech Sound Galaxy (non-PnP) cards"
 	depends on SOUND_OSS
diff -puN sound/oss/Makefile~ahum-merge-ad1889 sound/oss/Makefile
--- linux-2.5.75-20030711_0808/sound/oss/Makefile~ahum-merge-ad1889	Sat Jul 12 00:40:26 2003
+++ linux-2.5.75-20030711_0808-fr/sound/oss/Makefile	Sat Jul 12 00:40:26 2003
@@ -33,6 +33,7 @@ obj-$(CONFIG_SOUND_VIDC)	+= vidc_mod.o
 obj-$(CONFIG_SOUND_WAVEARTIST)	+= waveartist.o
 obj-$(CONFIG_SOUND_SGALAXY)	+= sgalaxy.o ad1848.o
 obj-$(CONFIG_SOUND_AD1816)	+= ad1816.o
+obj-$(CONFIG_SOUND_AD1889)	+= ad1889.o ac97_codec.o
 obj-$(CONFIG_SOUND_ACI_MIXER)	+= aci.o
 obj-$(CONFIG_SOUND_AWE32_SYNTH)	+= awe_wave.o
 

_

  reply	other threads:[~2003-07-11 22:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-11 18:21 PATCH: Merge AD1889 driver from 2.4 Alan Cox
2003-07-11 22:45 ` Francois Romieu [this message]
2003-07-11 22:57   ` [PATCH] Fix error path in AD1889 driver Francois Romieu
2003-07-13  8:11     ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030712004501.B25528@electric-eye.fr.zoreil.com \
    --to=romieu@fr.zoreil.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).