From: Pete Zaitcev <zaitcev@redhat.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: PATCH: update ymfpci for new ac97
Date: Fri, 11 Jul 2003 21:59:16 -0400 [thread overview]
Message-ID: <200307120159.h6C1xGL12421@devserv.devel.redhat.com> (raw)
In-Reply-To: <mailman.1057949943.19028.linux-kernel2news@redhat.com>
> --- linux-2.5.75/sound/oss/ymfpci.c 2003-07-10 21:11:35.000000000 +0100
> +++ linux-2.5.75-ac1/sound/oss/ymfpci.c 2003-07-11 16:59:04.000000000 +0100
> @@ -2462,7 +2474,7 @@
> }
>
> eid = ymfpci_codec_read(codec, AC97_EXTENDED_ID);
> - if (eid==0xFFFFFF) {
> + if (eid==0xFFFF) {
> printk(KERN_WARNING "ymfpci: no codec attached ?\n");
> goto out_kfree;
> }
ok, I think it's all right for 2.5, though for 2.4 I just removed
the check. Consider that it was not working for the whole life
time of the driver, and not a single soul complained. Don't forget
to fix cs46xx, the origin of this copy-n-paste.
-- Pete
next parent reply other threads:[~2003-07-12 1:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.1057949943.19028.linux-kernel2news@redhat.com>
2003-07-12 1:59 ` Pete Zaitcev [this message]
2003-07-11 18:18 PATCH: update ymfpci for new ac97 Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200307120159.h6C1xGL12421@devserv.devel.redhat.com \
--to=zaitcev@redhat.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).