linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Albert Cahalan <albert@users.sourceforge.net>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	akpm@digeo.com, torvalds@osdl.org
Subject: Re: [PATCH] /proc/bus/pci* changes
Date: Sun, 13 Jul 2003 21:53:04 -0700	[thread overview]
Message-ID: <20030714045304.GB19392@kroah.com> (raw)
In-Reply-To: <1058154708.747.1391.camel@cube>

On Sun, Jul 13, 2003 at 11:51:48PM -0400, Albert Cahalan wrote:
> The existing /proc/bus/pci/*/* files are a
> hack involving ioctl and out-of-bounds mmap.
> The following patch starts a transition to
> something sane while keeping compatibility.
> 
> Typical user-space drivers for polled devices
> should be easy to port to the new interface.
> The X server will need some per-arch enhancements
> to handle write-combining (non-x86 lack MTRRs)
> and the use of multiple VGA-style devices.
> 
> In the new interface, pci/00/00.0 is a symbolic
> link to a ../../pci*/bus0/dev0/fn0/config-space
> file, where the '*' is typically 0. (PCI domain)
> Simple and direct per-resource mmap() is provided,
> via pci0/bus0/dev0/fn0/bar0 and so on.

Why put all of these extra directories in /proc?  We talked about this
before...

What are you trying to "transition to"?  What do you want to see this
look like when you are finished?  And are you prepared to patch all of
the userspace programs that currently rely on the existing interface
(like XFree86 for one)?

Also, I don't think you are handling the pci domain space in your patch,
or am I just missing it?

And your patch was linewrapped :)

thanks,

greg k-h

  reply	other threads:[~2003-07-14  4:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-14  3:51 [PATCH] /proc/bus/pci* changes Albert Cahalan
2003-07-14  4:53 ` Greg KH [this message]
2003-07-14  5:40   ` Albert Cahalan
2003-07-14 17:38     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030714045304.GB19392@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@digeo.com \
    --cc=albert@users.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).