From: Greg KH <greg@kroah.com>
To: Stephen Smalley <sds@epoch.ncsc.mil>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
Alexander Viro <viro@parcelfarce.linux.theplanet.co.uk>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Christoph Hellwig <hch@infradead.org>,
Chris Wright <chris@wirex.com>,
James Morris <jmorris@intercode.com.au>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Add SELinux module to 2.6.0-test1
Date: Mon, 14 Jul 2003 12:16:25 -0700 [thread overview]
Message-ID: <20030714191625.GA24578@kroah.com> (raw)
In-Reply-To: <1058209504.13738.687.camel@moss-huskers.epoch.ncsc.mil>
On Mon, Jul 14, 2003 at 03:05:04PM -0400, Stephen Smalley wrote:
> The patch available from
> http://www.nsa.gov/selinux/lk/2.6.0-test1-addselinux.patch.gz adds the
> SELinux module under security/selinux and modifies the security/Makefile
> and security/Kconfig files for SELinux.
Some minor coding style nits:
- you are creating your own typedefs, please don't. Use the
"struct foo" style instead.
- you have a number of printk() calls without a logging level.
Hm, looks like some of the functions doing this aren't ever
called at all (avc_dump_cache() is one example)...
- your function style should be changed to take advantage of the
kerneldoc functionality. avc_lookup() is a good example of
something that could benifit from this (don't put comments
within a function declaration...)
Other than that, the coding style looks real good.
thanks,
greg k-h
next prev parent reply other threads:[~2003-07-14 19:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-14 19:05 [PATCH] Add SELinux module to 2.6.0-test1 Stephen Smalley
2003-07-14 19:16 ` Greg KH [this message]
2003-07-14 19:25 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030714191625.GA24578@kroah.com \
--to=greg@kroah.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=chris@wirex.com \
--cc=hch@infradead.org \
--cc=jmorris@intercode.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=sds@epoch.ncsc.mil \
--cc=torvalds@osdl.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).