From: Vojtech Pavlik <vojtech@suse.cz>
To: jiho@c-zone.net
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Vojtech Pavlik <vojtech@suse.cz>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Subject: Re: IDE driver: CBLID revisited
Date: Tue, 15 Jul 2003 08:54:50 +0200 [thread overview]
Message-ID: <20030715065450.GE27368@ucw.cz> (raw)
In-Reply-To: <3F133E61.1050705@c-zone.net>
On Mon, Jul 14, 2003 at 04:36:01PM -0700, jiho@c-zone.net wrote:
> The first test checks the cable type bit, then if that fails the rest
> checks UDMA enabled with mode timing for UDMA-66 or better.
>
> But the last test, (((u >> i) & 7) < 8)), should have < 6.
Indeed, since 6 means (6+2)*7.5ns which is 60ns, which is the correct
threshold. I probably forgot to subtract the '2' ...
Please can you make patches for 2.4 and 2.6?
--
Vojtech Pavlik
SuSE Labs, SuSE CR
next prev parent reply other threads:[~2003-07-15 6:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-08 1:40 IDE driver: CBLID revisited jiho
[not found] ` <3F133E61.1050705@c-zone.net>
2003-07-15 6:54 ` Vojtech Pavlik [this message]
[not found] ` <3F162FA0.9040504@c-zone.net>
[not found] ` <20030717054737.GA23037@ucw.cz>
2003-07-19 22:14 ` jiho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030715065450.GE27368@ucw.cz \
--to=vojtech@suse.cz \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jiho@c-zone.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).