From: Michael Frank <mflt1@micrologica.com.hk>
To: Russell King <rmk@arm.linux.org.uk>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Pavel Machek <pavel@suse.cz>, John Belmonte <jvb@prairienet.org>
Subject: Re: 2.5.75-mm1 yenta-socket lsPCI IRQ reads incorrect
Date: Tue, 15 Jul 2003 13:31:37 +0800 [thread overview]
Message-ID: <200307151331.40428.mflt1@micrologica.com.hk> (raw)
In-Reply-To: <20030714155051.A31395@flint.arm.linux.org.uk>
On Monday 14 July 2003 22:50, Russell King wrote:
> On Mon, Jul 14, 2003 at 07:37:29PM +0800, Michael Frank wrote:
> > On Monday 14 July 2003 19:01, Russell King wrote:
> > > On Mon, Jul 14, 2003 at 05:28:24PM +0800, Michael Frank wrote:
> > > > Very funny - suspend/resume is not implemented ;)
> > >
> > > It hasn't been implemented properly for a long long time.
> > >
> > > I think I have all the bits necessary, but need testers willing to
> > > try stuff out. I'll produce a patch in the next couple of days.
> >
> > Thank you, I look forward to testing it.
>
> Ok, this is a rudimentary insertion of the pci_save_state/pci_restore_state
> calls into yenta_socket.c. This should result in the first 64 bytes
> of config space being saved and restored over suspend/resume cycles.
>
Applied to 2.5.75-mm1 + test patch below which also prints pci irq @0x3c
problems seen:
- yenta_probe pci_save_state saves irq as ff. Moved to end of function, result same
- both swsusp and ACPI/S3 do _not_ call yenta_suspend and yenta_init, so it still
wont work
Test Patch:
diff -uN drivers/pcmcia/yenta_socket.c.orig drivers/pcmcia/yenta_socket.c
--- drivers/pcmcia/yenta_socket.c.orig 2003-07-15 12:39:52.000000000 +0800
+++ drivers/pcmcia/yenta_socket.c 2003-07-15 13:17:39.000000000 +0800
@@ -577,7 +577,9 @@
struct yenta_socket *socket = container_of(sock, struct yenta_socket, socket);
pci_set_power_state(socket->dev, 0);
- pci_restore_state(socket->dev, socket->saved_state);
+ printk("Yenta: init restore state %x\n",(u8)socket->saved_state[0xf]);
+
+ pci_restore_state(socket->dev, socket->saved_state);
yenta_config_init(socket);
yenta_clear_maps(socket);
@@ -596,6 +598,7 @@
/* Disable interrupts */
cb_writel(socket, CB_SOCKET_MASK, 0x0);
+ printk("Yenta: suspend save state %x\n",(u8)socket->saved_state[0xf]);
pci_save_state(socket->dev, socket->saved_state);
/*
@@ -867,8 +870,6 @@
/* Set up the bridge regions.. */
yenta_allocate_resources(socket);
- pci_save_state(dev, socket->saved_state);
-
socket->cb_irq = dev->irq;
/* Do we have special options for the device? */
@@ -897,6 +898,10 @@
/* Figure out what the dang thing can do for the PCMCIA layer... */
yenta_get_socket_capabilities(socket, isa_interrupts);
printk("Socket status: %08x\n", cb_readl(socket, CB_SOCKET_STATE));
+ pci_save_state(dev, socket->saved_state);
+ printk("Yenta: probe saved state %x\n",(u8)socket->saved_state[0xf]);
+ (u8)socket->saved_state[0xf] = socket->cb_irq;
+ printk("Yenta: probe saved state irq fixed %x\n",(u8)socket->saved_state[0xf]);
/* Register it with the pcmcia layer.. */
return pcmcia_register_socket(&socket->socket);
Regards
Michael
--
Powered by linux-2.5.75-mm1. Compiled with gcc-2.95-3 - mature and rock solid
My current linux related activities:
- 2.5 yenta_socket testing
- Test development and testing of swsusp for 2.4/2.5 and ACPI S3 of 2.5 kernel
- Everyday usage of 2.5 kernel
More info on 2.5 kernel: http://www.codemonkey.org.uk/post-halloween-2.5.txt
More info on swsusp: http://sourceforge.net/projects/swsusp/
next prev parent reply other threads:[~2003-07-15 5:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-14 5:41 Yenta_socket lsPCI IRQ reads incorrect Michael Frank
2003-07-14 9:07 ` Pavel Machek
2003-07-14 9:28 ` 2.5.75-mm1 yenta-socket " Michael Frank
2003-07-14 11:01 ` Russell King
2003-07-14 11:37 ` Michael Frank
2003-07-14 14:50 ` Russell King
2003-07-14 15:04 ` Jeff Garzik
2003-07-14 15:21 ` Russell King
2003-07-14 15:18 ` Michael Frank
2003-07-14 15:34 ` Russell King
2003-07-14 15:27 ` Michael Frank
2003-07-15 5:31 ` Michael Frank [this message]
2003-07-15 6:08 ` Michael Frank
2003-07-15 7:56 ` Russell King
2003-07-15 9:34 ` Michael Frank
2003-07-15 10:42 ` Michael Frank
2003-07-15 14:39 ` Russell King
2003-07-15 16:09 ` Michael Frank
2003-07-16 3:16 ` Michael Frank
2003-07-16 5:04 ` Michael Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200307151331.40428.mflt1@micrologica.com.hk \
--to=mflt1@micrologica.com.hk \
--cc=jvb@prairienet.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).