linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: "James H. Cloos Jr." <cloos@jhcloos.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: /sys/class/tty bugglet in 2.6.0-test1 +
Date: Tue, 15 Jul 2003 14:09:58 -0700	[thread overview]
Message-ID: <20030715210958.GA5368@kroah.com> (raw)
In-Reply-To: <m3brvvzh4m.fsf@lugabout.jhcloos.org>

On Tue, Jul 15, 2003 at 04:09:45PM -0400, James H. Cloos Jr. wrote:
> It looks like sysfs is creating a dir in class/tty by the name of
> usb/acm/0 for my acm modem:
> 
> :; ls -AF /sys/class/tty
> total 0
>    0 console/
>    0 ptmx/
>    0 tty/
>    0 tty0/
> [ tty1 to tty63 elided ]
>    0 ttyS0/
>    0 ttyS1/
>    0 ttyS2/
>    0 ttyS3/
>    0 usb/acm/0/

Ouch, someone forgot to fix up this driver's devfs_name logic.  The
patch below should fix it.  Let me know if it doesn't work for you.

greg k-h


# USB: fix up cdc-acm driver's tty and devfs names.

diff -Nru a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
--- a/drivers/usb/class/cdc-acm.c	Tue Jul 15 14:08:30 2003
+++ b/drivers/usb/class/cdc-acm.c	Tue Jul 15 14:08:30 2003
@@ -765,7 +765,8 @@
 		return -ENOMEM;
 	acm_tty_driver->owner = THIS_MODULE,
 	acm_tty_driver->driver_name = "acm",
-	acm_tty_driver->name = "usb/acm/",
+	acm_tty_driver->name = "ttyACM",
+	acm_tty_driver->devfs_name = "usb/acm/",
 	acm_tty_driver->major = ACM_TTY_MAJOR,
 	acm_tty_driver->minor_start = 0,
 	acm_tty_driver->type = TTY_DRIVER_TYPE_SERIAL,

      reply	other threads:[~2003-07-15 20:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-15 20:09 /sys/class/tty bugglet in 2.6.0-test1 + James H. Cloos Jr.
2003-07-15 21:09 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030715210958.GA5368@kroah.com \
    --to=greg@kroah.com \
    --cc=cloos@jhcloos.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).