linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Jones <davej@codemonkey.org.uk>
To: Hugh Dickins <hugh@veritas.com>
Cc: Ron Niles <Ron.Niles@falconstor.com>, linux-kernel@vger.kernel.org
Subject: Re: Question about free_one_pgd() changes in these 3.5G patches
Date: Wed, 16 Jul 2003 16:25:32 +0100	[thread overview]
Message-ID: <20030716152532.GA18350@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.44.0307161242280.1549-100000@localhost.localdomain>

On Wed, Jul 16, 2003 at 01:31:39PM +0100, Hugh Dickins wrote:

Both this..

 > > 	for (j = 0; j < PTRS_PER_PMD ; j++) {
 > >  		prefetchw(pmd+j+(PREFETCH_STRIDE/16));
 > > 		free_one_pmd(pmd+j);
 > > 	}

and this..

 > > 	pmd_t * pmd, * md, * emd;
 > > 	for (md = pmd, emd = pmd + PTRS_PER_PMD; md < emd; md++) {
 > > 		prefetchw(md+(PREFETCH_STRIDE/16));
 > > 		free_one_pmd(md);
 > >  	}

both use the prefetch that was removed in 2.5 for 'being bogus'.
It can prefetch past the end iirc, which is fatal on some CPUs.

		Dave


  reply	other threads:[~2003-07-16 15:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-16  0:52 Question about free_one_pgd() changes in these 3.5G patches Ron Niles
2003-07-16 12:31 ` Hugh Dickins
2003-07-16 15:25   ` Dave Jones [this message]
2003-07-16 18:57     ` Hugh Dickins
2003-07-16 13:23 Ron Niles

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030716152532.GA18350@suse.de \
    --to=davej@codemonkey.org.uk \
    --cc=Ron.Niles@falconstor.com \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).