From: Adrian Bunk <bunk@fs.tum.de>
To: reiserfs-list@namesys.com
Cc: linux-kernel@vger.kernel.org, Randy Hron <rwhron@earthlink.net>,
trivial@rustcorp.com.au
Subject: [2.6 patch] remove four superfluous BUG's in ReiserFS
Date: Thu, 17 Jul 2003 00:57:22 +0200 [thread overview]
Message-ID: <20030716225722.GA1407@fs.tum.de> (raw)
The trivial patch below by Randy Hron still applies agains 2.6.0-test1.
Please apply
Adrian
----- Forwarded message from rwhron@earthlink.net -----
Date: Tue, 15 Apr 2003 10:30:24 -0400
From: rwhron@earthlink.net
To: linux-kernel@vger.kernel.org,
reiserfs-list@namesys.com
Subject: Re: BUGed to death
The patch below eliminates 4 BUG() calls that clearly
cannot happen based on the context.
--- linux-2.5.67-mm2/fs/reiserfs/hashes.c.orig 2003-04-15 10:11:44.000000000 -0400
+++ linux-2.5.67-mm2/fs/reiserfs/hashes.c 2003-04-15 10:13:43.000000000 -0400
@@ -90,10 +90,6 @@
if (len >= 12)
{
- //assert(len < 16);
- if (len >= 16)
- BUG();
-
a = (u32)msg[ 0] |
(u32)msg[ 1] << 8 |
(u32)msg[ 2] << 16|
@@ -116,9 +112,6 @@
}
else if (len >= 8)
{
- //assert(len < 12);
- if (len >= 12)
- BUG();
a = (u32)msg[ 0] |
(u32)msg[ 1] << 8 |
(u32)msg[ 2] << 16|
@@ -137,9 +130,6 @@
}
else if (len >= 4)
{
- //assert(len < 8);
- if (len >= 8)
- BUG();
a = (u32)msg[ 0] |
(u32)msg[ 1] << 8 |
(u32)msg[ 2] << 16|
@@ -154,9 +144,6 @@
}
else
{
- //assert(len < 4);
- if (len >= 4)
- BUG();
a = b = c = d = pad;
for(i = 0; i < len; i++)
{
--
Randy Hron
http://home.earthlink.net/~rwhron/kernel/bigbox.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
----- End forwarded message -----
next reply other threads:[~2003-07-16 22:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-16 22:57 Adrian Bunk [this message]
2003-07-23 23:11 [2.6 patch] remove four superfluous BUG's in ReiserFS rwhron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030716225722.GA1407@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-list@namesys.com \
--cc=rwhron@earthlink.net \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).