linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Mundt <lethal@linux-sh.org>
To: Miguel Sousa Filipe <m3thos@netcabo.pt>
Cc: Mikael Pettersson <mikpe@csd.uu.se>, linux-kernel@vger.kernel.org
Subject: Re: 2.6.0-test1  doesn't compile on PPC iBook2.2
Date: Wed, 16 Jul 2003 21:28:58 -0400	[thread overview]
Message-ID: <20030717012858.GA11672@linux-sh.org> (raw)
In-Reply-To: <3F15F471.3000004@netcabo.pt>

[-- Attachment #1: Type: text/plain, Size: 1689 bytes --]

On Thu, Jul 17, 2003 at 01:57:21AM +0100, Miguel Sousa Filipe wrote:
> >  CC      arch/ppc/platforms/pmac_nvram.o
> >  CC      arch/ppc/platforms/pmac_cpufreq.o
> >arch/ppc/platforms/pmac_cpufreq.c: In function `do_set_cpu_speed':
> >arch/ppc/platforms/pmac_cpufreq.c:179: `CPUFREQ_ALL_CPUS' undeclared 
> >(first use in this function)
> >arch/ppc/platforms/pmac_cpufreq.c:179: (Each undeclared identifier is 
> >reported only once
> >arch/ppc/platforms/pmac_cpufreq.c:179: for each function it appears in.)
> >make[1]: *** [arch/ppc/platforms/pmac_cpufreq.o] Error 1
> >make: *** [arch/ppc/platforms] Error 2
> >

This means that the driver hasn't been updated for the new cpufreq API changes.

CPUFREQ_ALL_CPUS is deprecated, as is the /proc interface (which is what
proc_intf.c references), since now the sysfs interface is preferred.

The pmac_cpufreq.c driver will likely need to be updated a bit (which may
already be done in the LinuxPPC trees) in order to build or function.

Notably, the verify stuff needs to be changed around quite a bit, since instead
of doing the range validation and wrapping to cpufreq_verify_within_limits(), a
frequency table is built up instead and subsequently passed through
cpufreq_frequency_table_verify(). Take a look at some of the existing cpufreq
drivers that are up-to-date for ideas on how to do this (most of the i386 ones,
the SuperH one, and probably others).

As such, you can either look at updating the driver (if this hasn't already
been done by the LinuxPPC folk), or you can just not build it in. Probably no
good things will happen if you hack it to the point of building and then
attempt to use it.


[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]

  reply	other threads:[~2003-07-17  1:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-17  0:15 2.6.0-test1 doesn't compile on PPC iBook2.2 Mikael Pettersson
2003-07-17  0:32 ` Miguel Sousa Filipe
2003-07-17  0:57   ` Miguel Sousa Filipe
2003-07-17  1:28     ` Paul Mundt [this message]
2003-07-17  1:48       ` Miguel Sousa Filipe
2003-07-17  1:55         ` Paul Mundt
  -- strict thread matches above, loose matches on Subject: below --
2003-07-16 21:14 Miguel Sousa Filipe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030717012858.GA11672@linux-sh.org \
    --to=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m3thos@netcabo.pt \
    --cc=mikpe@csd.uu.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).