linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Isapnp warning
@ 2003-06-15 18:36 Geert Uytterhoeven
  2003-06-21 12:31 ` Alan Cox
  0 siblings, 1 reply; 42+ messages in thread
From: Geert Uytterhoeven @ 2003-06-15 18:36 UTC (permalink / raw)
  To: Linus Torvalds, perex; +Cc: Linux Kernel Development, Geert Uytterhoeven

Isapnp: Kill warning if CONFIG_PCI is not set

--- linux-2.5.x/drivers/pnp/resource.c	Tue May 27 19:03:04 2003
+++ linux-m68k-2.5.x/drivers/pnp/resource.c	Sun Jun  8 13:31:20 2003
@@ -97,7 +97,9 @@
 
 int pnp_add_irq_resource(struct pnp_dev *dev, int depnum, struct pnp_irq *data)
 {
+#ifdef CONFIG_PCI
 	int i;
+#endif
 	struct pnp_resources *res;
 	struct pnp_irq *ptr;
 	res = pnp_find_resources(dev,depnum);

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

^ permalink raw reply	[flat|nested] 42+ messages in thread
* Re: GCC speed (was [PATCH] Isapnp warning)
@ 2003-06-22 19:03 John Bradford
  0 siblings, 0 replies; 42+ messages in thread
From: John Bradford @ 2003-06-22 19:03 UTC (permalink / raw)
  To: akpm, phillips; +Cc: acme, alan, cw, geert, linux-kernel, perex, torvalds

> No.  Compilation inefficiency directly harms programmer efficiency and the
> quality and volume of code the programmer produces.  These are surely the
> most important things by which a toolchain's usefulness should be judged.
>
> I compile with -O1 all the time and couldn't care the teeniest little bit
> about the performance of the generated code - it just doesn't matter.
>
> I'm happy allowing those thousands of people who do not compile kernels all
> the time to shake out any 3.2/3.3 compilation problems.
>
>
> Compilation inefficiency is the most serious thing wrong with gcc.

Code for hardware that almost nobody has anymore isn't easily tested
for subtle compilation errors.

The math emulation code didn't even compile for a while, and that went
unnoticed.  IFF there are substantial benefits to dropping 2.95.3
should we risk drivers for things like obscure SCSI cards being
mis-compiled and randomly corrupting data.

There _must_ be hardware that nobody has tested a gcc 3 compiled
kernel on.

All 2.5.X trees, and most 2.4.x trees have had a _lot_ of testing with
GCC 2.95.3, in a lot of different environments.  Especially in the
case of 2.4.X, a lot of that code hasn't seen significant changes in
the last year or so, and those code paths have been shown to be very
stable with gcc 2.95.3.

Eliminating gcc 2.95.3 support when a lot of people are still using
it, and having a large number of users migrate to gcc 3.3 could
uncover subtle compiler bugs a month or two later, and we'd end up
having to either live with that, or add support for gcc 2.95.3 back
in.

John.

^ permalink raw reply	[flat|nested] 42+ messages in thread
* Re: GCC speed (was [PATCH] Isapnp warning)
@ 2003-06-22 20:07 John Bradford
  2003-06-22 20:27 ` Michael Buesch
  0 siblings, 1 reply; 42+ messages in thread
From: John Bradford @ 2003-06-22 20:07 UTC (permalink / raw)
  To: akpm, hps; +Cc: linux-kernel

> No, the build system is OK.  And ccache nicely fixes up any mistakes which
> the build system makes, and distcc speeds things up by 2x to 3x.
>
> None of that gets around the fact that code needs to be tested with various
> combinations of CONFIG_SMP, CONFIG_PREEMPT, different subarchitectures,
> spinlock debugging, etc, etc.  If the compiler is slow people don't bother
> doing this and the code breaks.
>
> Cause and effect.

Are the benchmarks that show gcc 3.3 to be much slower at compile time
being done with a natively compiled gcc 3.3?  I.E. gcc 3.3 compiled
with itself?

When I upgraded a few machines from 2.95.3 to 3.2.3, I noticed that
the last of the three compiles, (I.E. a gcc-3.2.3 compiled gcc-3.2.3
compiling the gcc-3.2.3 source), was noticably quicker than the first
two, to the extent that it was easily mesaurable by a wall clock.

I am just wondering whether there gcc-3.X binaries in use that were
compiled with gcc-2.95.3, that are swaying benchmarks in favour of
2.95.3 compiled with itself.

I haven't benchmarked gcc-2.95.3 compiled with gcc-3.2.3, though.

John.

^ permalink raw reply	[flat|nested] 42+ messages in thread
* Re: GCC speed (was [PATCH] Isapnp warning)
@ 2003-06-23  7:40 John Bradford
  2003-06-23 13:17 ` Larry McVoy
  0 siblings, 1 reply; 42+ messages in thread
From: John Bradford @ 2003-06-23  7:40 UTC (permalink / raw)
  To: akpm, lm; +Cc: acme, alan, cw, geert, linux-kernel, perex, phillips, torvalds

> If you think 3.[23] are slow, go back and compile with 2.7.2 - it's much
> faster than the later versions.  I used to yank newer versions of gcc
> off systems and put 2.7.2 on, I think it was close to 2x faster at
> compilation and made no difference on BK performance.

Out of interest, have you tried compiling BK with tcc?

John.

^ permalink raw reply	[flat|nested] 42+ messages in thread

end of thread, other threads:[~2003-07-17 10:13 UTC | newest]

Thread overview: 42+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-06-15 18:36 [PATCH] Isapnp warning Geert Uytterhoeven
2003-06-21 12:31 ` Alan Cox
2003-06-21 14:59   ` Geert Uytterhoeven
2003-06-21 15:04     ` Sean Neakums
2003-06-21 19:51     ` Andrew Morton
2003-06-21 23:53       ` Linus Torvalds
2003-06-22  0:11         ` Arnaldo Carvalho de Melo
2003-06-22  1:41           ` Chris Wedgwood
2003-06-22  1:43             ` Arnaldo Carvalho de Melo
2003-06-22  2:17               ` Andrew Morton
2003-06-22  2:27                 ` Chris Wedgwood
2003-06-22  2:59                   ` Andrew Morton
2003-06-22  5:50                     ` Herbert Xu
2003-06-22  3:43                 ` Martin J. Bligh
2003-06-22  4:24                 ` Paul Mackerras
2003-06-22  8:32                   ` Geert Uytterhoeven
2003-06-22 13:34                     ` Daniel Phillips
2003-06-22  5:39                 ` gcc 3.3: largest *and* smallest kernels (was Re: [PATCH] Isapnp warning) Barry K. Nathan
2003-06-22 11:31                   ` Alan Cox
2003-06-22 13:22                 ` GCC speed (was " Daniel Phillips
2003-06-22 17:32                   ` Andrew Morton
2003-06-22 17:56                     ` Linus Torvalds
2003-06-22 18:58                     ` Henning P. Schmiedehausen
2003-06-22 19:12                       ` Sam Ravnborg
2003-06-22 19:13                       ` Andrew Morton
2003-06-22 19:32                         ` Henning Schmiedehausen
2003-06-22 19:51                       ` Adrian Bunk
2003-06-22 19:12                     ` Daniel Phillips
2003-06-23  1:05                     ` Larry McVoy
2002-01-04 11:32                       ` Pavel Machek
2003-07-17 10:18                         ` Christoph Hellwig
2003-07-17 10:23                           ` Jakub Jelinek
2003-07-17 10:27                             ` Christoph Hellwig
2003-06-22  8:49               ` [PATCH] Isapnp warning Russell King
2003-06-22  8:39             ` Jörn Engel
2003-06-22 14:07   ` Daniel Phillips
2003-06-22 15:00     ` Jan-Benedict Glaw
2003-06-22 19:03 GCC speed (was [PATCH] Isapnp warning) John Bradford
2003-06-22 20:07 John Bradford
2003-06-22 20:27 ` Michael Buesch
2003-06-23  7:40 John Bradford
2003-06-23 13:17 ` Larry McVoy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).