archive mirror
 help / color / mirror / Atom feed
From: Gerd Knorr <>
To: Greg KH <>
Cc: Kernel List <>,
	video4linux list <>
Subject: Re: [RFC/PATCH] sysfs'ify video4linux
Date: Thu, 17 Jul 2003 18:37:15 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

> > ... if a ->release() callback is required anyway to fix it?  I see two
> > ways to handle it:
> > 
> >   (1) mandatory ->release() callback, drivers must make sure the stuff
> >       is not freed before the callback was called.  In that case the
> >       class_device can be left embedded inside the drivers provate
> >       structs.
> That sounds fine, and is the same as what I did for usb host devices.


> >   (2) optional ->release() callback (for those drivers which want add
> >       private attributes), "struct video_device" must be moved out of
> >       the drivers private structs then and released in a new function
> >       (which also calls the drivers ->release callback if present).
> >       Should probably also be allocated by videodev.c for symmetry.
> That's "prettier", but probably requires a lot more work in every v4l
> driver, right?

Not sure which of them is actually more work.

Version (1) can be done without breaking the build, with a hack along 
the lines "if (no release callback) printk(KERN_WARN please fix your
driver)", so the drivers can be fixed step-by-step afterwards.

Fixing the drivers might be non-trivial through.  Some drivers are
hot-pluggable (usb cams), some drivers register more than one v4l device
(bttv wants up to three).  Those drivers can't just call kfree() in the
->release callback because there might be other references, some open
file handle for a unplugged usb cam, another not-yet unregistered
v4l device, whatever.  Probably they must implement some reference
counting scheme to get that right.  The very simple ones (in
drivers/media/radio for example) likely just need the kfree() moved
from the ->remove function into the new ->release() callback.

Version (2) needs every v4l driver touched to make it compile again.
Not sure how hard it is to fixup them.  I'd guess it is pretty straigt
forward to do the conversion, it's just alot of work.  I also could do
a number of other cleanups along the way.  Maybe I trap into some hidden
pitfalls through, havn't looked at all the drivers in detail yet.



  reply	other threads:[~2003-07-17 16:09 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-15 14:31 [RFC/PATCH] sysfs'ify video4linux Gerd Knorr
2003-07-15 15:21 ` Ronald Bultje
2003-07-15 16:19   ` Matt Porter
2003-07-15 21:27 ` Greg KH
2003-07-16  8:44   ` Gerd Knorr
2003-07-16 16:19     ` Greg KH
2003-07-16 20:20       ` Gerd Knorr
2003-07-16 21:08         ` Greg KH
2003-07-17 12:01           ` Gerd Knorr
2003-07-17 14:57             ` Greg KH
2003-07-17 16:37               ` Gerd Knorr [this message]
2003-07-17 21:49                 ` Greg KH
2003-07-18  9:59                   ` Gerd Knorr
     [not found]                     ` <>
2003-07-21  7:28                       ` Gerd Knorr
2003-07-21  7:55                         ` Ronald Bultje
2003-07-21 15:43                         ` [RFC/PATCH] 1/2 v4l: sysfs'ify video4linux core Gerd Knorr
2003-07-21 15:47                           ` [RFC/PATCH] 2/2 v4l: sysfs'ify bttv driver Gerd Knorr
2003-07-21 16:27                           ` [RFC/PATCH] 1/2 v4l: sysfs'ify video4linux core Greg KH
2003-07-16 13:33   ` [RFC/PATCH] sysfs'ify video4linux Mark McClelland
2003-07-16 14:10     ` root
2003-07-16 16:23     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).